From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 19/22] bbu: Remove logical negation in barebox_update_handler_exists()
Date: Thu, 23 Aug 2018 08:42:45 +0200 [thread overview]
Message-ID: <20180823064245.hkxboqum2qxilifg@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqHr=a5CJrZ_ZhDUGxNu3Z48SVN4d30isVV4XVLZC1vy_g@mail.gmail.com>
On Wed, Aug 22, 2018 at 05:01:41PM -0700, Andrey Smirnov wrote:
> On Wed, Aug 22, 2018 at 12:09 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > On Mon, Aug 20, 2018 at 11:26:00PM -0700, Andrey Smirnov wrote:
> > > Returning !bbu_find_handler() from barebox_update_handler_exists()
> > > would return the opposite result from what the name of that funciton
> > > implies. Drop the "!" to make it behave as expected.
> > >
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > > ---
> > > common/bbu.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/common/bbu.c b/common/bbu.c
> > > index 11e44f4a7..69ccac68a 100644
> > > --- a/common/bbu.c
> > > +++ b/common/bbu.c
> > > @@ -151,7 +151,7 @@ bool barebox_update_handler_exists(struct bbu_data *data)
> > > if (!data->handler_name)
> > > return false;
> > >
> > > - return !bbu_find_handler(data->handler_name);
> > > + return bbu_find_handler(data->handler_name);
> >
> > As bbu_find_handler() returns a pointer maybe better '!!' or
> > bbu_find_handler() != NULL?
> >
>
> That shouldn't be necessary since barebox_update_handler_exists()
> returns bool(real type name is _Bool) which explicitly specifies that
> a cast of any scalar value to it would be normalized to 1 or 0 (as per
> C99 standard from whence it came). Otherwise you'd be able to end up
> in a situation where bool1 && bool2 && (bool1 != bool2) evaluates to
> true.
>
> To give you more concrete example, here's what the last portion of
> that function compiles to on AArch64:
>
> 2924: 97ffff5e bl 269c <bbu_find_handler>
> 2928: f100001f cmp x0, #0x0
> 292c: 1a9f07e0 cset w0, ne // ne = any
> 2930: f9400bf3 ldr x19, [sp, #16]
> 2934: a8c27bfd ldp x29, x30, [sp], #32
> 2938: d65f03c0 ret
> 293c: 52800020 mov w0, #0x1 // #1
> 2940: 17fffffc b 2930 <barebox_update_handler_exists+0x30>
> 2944: 52800000 mov w0, #0x0 // #0
> 2948: 17fffffa b 2930 <barebox_update_handler_exists+0x30>
>
> and on AArch32 (Thumb):
>
> 18e0: f7ff ff48 bl 1774 <bbu_find_handler>
> 18e4: 3000 adds r0, #0
> 18e6: bf18 it ne
> 18e8: 2001 movne r0, #1
> 18ea: bd10 pop {r4, pc}
> 18ec: 2001 movs r0, #1
> 18ee: e7fc b.n 18ea <barebox_update_handler_exists+0x1a>
>
> as you can see both cases already have code to explicitly convert the
> result of the function to 0/1.
>
> I am more than happy to add ether !! or != NULL if you still think
> that'd be better, it just I don't think it will have any practical
> effect.
For sure it doesn't have a practical effect, it's merely a sign to show
"I know I'm casting a pointer to bool". Probably I'm just used to add
an explicit cast there and it's just a matter of taste.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-23 6:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 6:25 [PATCH 00/22] i.MX BBU improvements and bugfixes Andrey Smirnov
2018-08-21 6:25 ` [PATCH 01/22] ARM: i.MX: bbu: Remove unused define Andrey Smirnov
2018-08-21 6:25 ` [PATCH 02/22] filetype: Add code to detect i.MX image v1 Andrey Smirnov
2018-08-21 10:07 ` Roland Hieber
2018-08-21 20:23 ` Andrey Smirnov
2018-08-23 9:33 ` Roland Hieber
2018-08-23 21:01 ` Andrey Smirnov
2018-08-21 6:25 ` [PATCH 03/22] filetype: Add code to detect i.MX image v2 Andrey Smirnov
2018-08-21 6:25 ` [PATCH 04/22] ARM: i.MX: bbu: Move inner-image type check Andrey Smirnov
2018-08-22 6:49 ` Sascha Hauer
2018-08-22 6:52 ` Sascha Hauer
2018-08-23 0:06 ` Andrey Smirnov
2018-08-23 6:44 ` Sascha Hauer
2018-08-21 6:25 ` [PATCH 05/22] ARM: i.MX: bbu: Drop IMX_INTERNAL_FLAG_NAND Andrey Smirnov
2018-08-21 6:25 ` [PATCH 06/22] ARM: i.MX: bbu: Consolidate vairous update helpers Andrey Smirnov
2018-08-22 6:52 ` Sascha Hauer
2018-08-23 0:07 ` Andrey Smirnov
2018-08-21 6:25 ` [PATCH 07/22] ARM: i.MX: bbu: Simplify imx53_bbu_internal_nand_register_handler() Andrey Smirnov
2018-08-21 6:25 ` [PATCH 08/22] ARM: i.MX: bbu: Constify all 'devicefile' arguments Andrey Smirnov
2018-08-21 6:25 ` [PATCH 09/22] ARM: i.MX: bbu: Detect which platforms need v2 i.MX header Andrey Smirnov
2018-08-21 6:25 ` [PATCH 10/22] ARM: i.MX: bbu: Alias imx5*_bbu_internal_mmc_register_handler() Andrey Smirnov
2018-08-21 6:25 ` [PATCH 11/22] ARM: i.MX: bbu: Alias imx5*_bbu_internal_spi_i2c_register_handler() Andrey Smirnov
2018-08-21 6:25 ` [PATCH 12/22] ARM: i.MX: bbu: Move protect code into a separate routine Andrey Smirnov
2018-08-21 6:25 ` [PATCH 13/22] ARM: i.MX: bbu: Adjust FLASH_HEADER_OFFSET_MMC for i.MX8MQ Andrey Smirnov
2018-08-21 6:25 ` [PATCH 14/22] ARM: i.MX: bbu: Add support for SPI/I2C on VFxxx Andrey Smirnov
2018-08-21 6:25 ` [PATCH 15/22] ARM: i.MX: zii-vf610-dev-rev-b/c: Add support for BBU on SPI-NOR Andrey Smirnov
2018-08-21 6:25 ` [PATCH 16/22] ARM: i.MX: bbu: Add support for MMC on i.MX8MQ Andrey Smirnov
2018-08-21 6:25 ` [PATCH 17/22] ARM: nxp-imx8mq-evk: Add eMMC BBU configuration Andrey Smirnov
2018-08-21 6:25 ` [PATCH 18/22] ARM: i.MX: bbu: Adjust error code check for pwrite() Andrey Smirnov
2018-08-22 7:01 ` Sascha Hauer
2018-08-23 0:16 ` Andrey Smirnov
2018-08-21 6:26 ` [PATCH 19/22] bbu: Remove logical negation in barebox_update_handler_exists() Andrey Smirnov
2018-08-22 7:09 ` Sascha Hauer
2018-08-23 0:01 ` Andrey Smirnov
2018-08-23 4:43 ` Sam Ravnborg
2018-08-23 6:42 ` Sascha Hauer [this message]
2018-08-23 6:48 ` Andrey Smirnov
2018-08-21 6:26 ` [PATCH 20/22] block: Do not ignore error in blk->ops->write() Andrey Smirnov
2018-08-21 6:26 ` [PATCH 21/22] bbu: Report update failures explicitly Andrey Smirnov
2018-08-21 6:26 ` [PATCH 22/22] bbu: command: Make sure specified update handler exists Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823064245.hkxboqum2qxilifg@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox