From: Sam Ravnborg <sam@ravnborg.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/3] i.MX8 malloc pool position and 32-bit only DMA
Date: Fri, 24 Aug 2018 19:15:20 +0200 [thread overview]
Message-ID: <20180824171520.GB16451@ravnborg.org> (raw)
In-Reply-To: <20180824030511.23021-1-andrew.smirnov@gmail.com>
Hi Andrey.
> This series is a result of debugging FEC and uSDHC failures on
> i.MX8MQ. Patches 1 and 2 are pretty straightforward and shouldn't be
> controversial. Patch 3, OTOH, may or may not be a good way to solve
> this problem, but it's a good way to start a discussion on the subject
> which is my main goal here.
>
> Feedback is welcome!
>
> Thanks,
> Andrey Smirnov
>
> Andrey Smirnov (3):
> mci: imx-esdhc: Bail out if DMA address is larger than 32-bits
> net: fec: Bail out if DMA address is larger than 32-bits
In the above patches the checks are distributed to the
users. Are there any reason why we could not centralize this
check in the dma code?
As I assume it is everyone that is constrained to the
32BIT address space.
And do we really need these checks if we teach
malloc to only provide memory that is DMA'able?
For the malloc bits I like that this change
is limited to ARM code and not in generic code.
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-24 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 3:05 Andrey Smirnov
2018-08-24 3:05 ` [PATCH 1/3] mci: imx-esdhc: Bail out if DMA address is larger than 32-bits Andrey Smirnov
2018-08-27 6:53 ` Sascha Hauer
2018-08-27 23:33 ` Andrey Smirnov
2018-08-24 3:05 ` [PATCH 2/3] net: fec: " Andrey Smirnov
2018-08-24 3:05 ` [PATCH 3/3] ARM: start: Place malloc pool within 32-bit address space Andrey Smirnov
2018-08-27 9:06 ` Sascha Hauer
2018-08-27 23:38 ` Andrey Smirnov
2018-08-24 17:15 ` Sam Ravnborg [this message]
2018-08-27 23:32 ` [PATCH 0/3] i.MX8 malloc pool position and 32-bit only DMA Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824171520.GB16451@ravnborg.org \
--to=sam@ravnborg.org \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox