From: Sascha Hauer <s.hauer@pengutronix.de>
To: Aleksander Morgado <aleksander@aleksander.es>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] ratp: implement i2c read/write support
Date: Mon, 27 Aug 2018 11:09:45 +0200 [thread overview]
Message-ID: <20180827090945.xxae7l6k2s2rug7v@pengutronix.de> (raw)
In-Reply-To: <CAAP7ucKR_tmawkX=DTO2bnzhT+L2A-AhChCXddgMEd5FCKpOYA@mail.gmail.com>
On Thu, Aug 23, 2018 at 10:54:58PM +0200, Aleksander Morgado wrote:
> >> +struct ratp_bb_i2c_read_request {
> >> + struct ratp_bb header;
> >> + uint16_t buffer_offset;
> >> + uint8_t bus;
> >> + uint8_t addr;
> >
> > I wonder how we see the RATP support. If it's for adhoc debugging then
> > bus/addr is fine. The caller should have no expectations that the bus
> > number is constant though. Likewise for the address which might change
> > across different board revisions.
> >
> > Should we have support for resolving names, which could be provided by
> > aliases in dt?
> >
> > We could still add name resolving support later as a separate call, I
> > just thought that now is the time to think how we proceed.
> >
>
> I truly have no opinion here, but if name resolving is added at some
> point I can either update this operation or even add a new one.
Ok, as said, we can add the name resolving functionality later. So, as
long as you don't see such numbering issues with the things you want to
do with RATP then I am fine with adding this when it's needed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-27 9:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 15:19 RATP i2c and GPIO support Aleksander Morgado
2018-08-21 15:19 ` [PATCH 1/4] ratp: implement i2c read/write support Aleksander Morgado
2018-08-21 19:38 ` Andrey Smirnov
2018-09-12 9:25 ` Aleksander Morgado
2018-08-22 7:46 ` Sascha Hauer
2018-08-23 20:54 ` Aleksander Morgado
2018-08-27 9:09 ` Sascha Hauer [this message]
2018-08-21 15:19 ` [PATCH 2/4] bbremote: " Aleksander Morgado
2018-08-21 15:20 ` [PATCH 3/4] ratp: implement support for GPIO commands Aleksander Morgado
2018-08-21 20:18 ` Andrey Smirnov
2018-08-22 7:52 ` Sascha Hauer
2018-08-21 15:20 ` [PATCH 4/4] bbremote: implement support for GPIO operations Aleksander Morgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827090945.xxae7l6k2s2rug7v@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=aleksander@aleksander.es \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox