From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 2/2] commands: barebox-update: Improve nonexistent handler reporting
Date: Wed, 29 Aug 2018 00:21:53 -0700 [thread overview]
Message-ID: <20180829072153.13428-2-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180829072153.13428-1-andrew.smirnov@gmail.com>
Convert code printing said error message to be more informative and
avoid printing <NULL> for handler name.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
commands/barebox-update.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/commands/barebox-update.c b/commands/barebox-update.c
index f76aa19a5..89aa9fddb 100644
--- a/commands/barebox-update.c
+++ b/commands/barebox-update.c
@@ -63,7 +63,15 @@ static int do_barebox_update(int argc, char *argv[])
}
if (!barebox_update_handler_exists(&data)) {
- printf("handler '%s' does not exist\n", data.handler_name);
+ if (data.handler_name)
+ printf("handler '%s' does not exist\n",
+ data.handler_name);
+ else if (data.devicefile)
+ printf("handler for '%s' does not exist\n",
+ data.devicefile);
+ else
+ printf("default handler does not exist\n");
+
print_handlers_list();
return COMMAND_ERROR;
}
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-08-29 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:21 [PATCH 1/2] bbu: Look for default handler in barebox_update_handler_exists() Andrey Smirnov
2018-08-29 7:21 ` Andrey Smirnov [this message]
2018-08-29 7:58 ` Sascha Hauer
2018-08-31 5:23 ` Andrey Smirnov
2018-08-31 6:40 ` Sascha Hauer
2018-09-04 6:35 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829072153.13428-2-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox