mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] bbu: Look for default handler in barebox_update_handler_exists()
Date: Tue, 4 Sep 2018 08:35:24 +0200	[thread overview]
Message-ID: <20180904063524.3yuvgpwvjetkx3p2@pengutronix.de> (raw)
In-Reply-To: <20180829072153.13428-1-andrew.smirnov@gmail.com>

On Wed, Aug 29, 2018 at 12:21:52AM -0700, Andrey Smirnov wrote:
> Convert barebox_update_handler_exists() to treat struct bbu_data with
> both "handler_name" and "devicefile" set to NULL as a specifier for
> default update handler in order to support such use-case for
> "barebox_update" and fix a recent regression.
> 
> This change shouldn't affect another user of
> barebox_update_handler_exists(), cb_flash() in
> drivers/usb/gadget/f_fastboot.c, since that function explicitly
> specifies "devicefile".
> 
> Fixes 0ac96ab6e ("bbu: command: Make sure specified update handler exists")

I dropped 0ac96ab6e for now, so you are free to implement a proper
solution on top of current next branch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2018-09-04  6:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  7:21 Andrey Smirnov
2018-08-29  7:21 ` [PATCH 2/2] commands: barebox-update: Improve nonexistent handler reporting Andrey Smirnov
2018-08-29  7:58 ` [PATCH 1/2] bbu: Look for default handler in barebox_update_handler_exists() Sascha Hauer
2018-08-31  5:23   ` Andrey Smirnov
2018-08-31  6:40     ` Sascha Hauer
2018-09-04  6:35 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904063524.3yuvgpwvjetkx3p2@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox