From: Sascha Hauer <sha@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] scripts imx-image: add support for newer versions of "cst"
Date: Tue, 4 Sep 2018 10:12:45 +0200 [thread overview]
Message-ID: <20180904081245.lne4kmkc75sbrsz3@pengutronix.de> (raw)
In-Reply-To: <20180903133212.17771-1-mkl@pengutronix.de>
On Mon, Sep 03, 2018 at 03:32:12PM +0200, Marc Kleine-Budde wrote:
> Older versions of "cst" want to read the CSF from STDIN, while newer versions
> want to read the CSF from a file. Sadly, the "-i" option doesn't understand
> "-i -" to read from STDIN, so we give it "/dev/stdin" instead.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> scripts/imx/imx-image.c | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c
> index b241e8c4b68e..ffde8149650f 100644
> --- a/scripts/imx/imx-image.c
> +++ b/scripts/imx/imx-image.c
> @@ -546,7 +546,28 @@ static int hab_sign(struct config_data *data)
> }
> }
>
> - ret = asprintf(&command, "%s -o %s", cst, csffile);
> + /*
> + * Older versions of "cst" want to read the CSF from STDIN,
> + * while newer versions want to read the CSF from a
> + * file. Sadly, the "-i" option doesn't understand "-i -" to
> + * read from STDIN, so we give it "/dev/stdin" instead.
> + */
> + ret = asprintf(&command,
> + "%s | grep 'Input CSF text filename'",
> + cst);
> + if (ret < 0)
> + return -ENOMEM;
> +
> + ret = system(command);
> + free(command);
> + if (ret == -1)
> + return -EINVAL;
> + else if (ret == 0)
> + ret = asprintf(&command, "%s -o %s -i /dev/stdin",
> + cst, csffile);
> + else
> + ret = asprintf(&command, "%s -o %s;",
> + cst, csffile);
> if (ret < 0)
> return -ENOMEM;
>
> --
> 2.18.0
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-09-04 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 13:32 Marc Kleine-Budde
2018-09-04 8:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904081245.lne4kmkc75sbrsz3@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox