From: Aleksander Morgado <aleksander@aleksander.es>
To: barebox@lists.infradead.org
Cc: andrew.smirnov@gmail.com, Aleksander Morgado <aleksander@aleksander.es>
Subject: [PATCH v2 5/7] ratp: use __packed instead of the full form
Date: Wed, 12 Sep 2018 15:45:48 +0200 [thread overview]
Message-ID: <20180912134550.3970-6-aleksander@aleksander.es> (raw)
In-Reply-To: <20180912134550.3970-1-aleksander@aleksander.es>
Just a minor coding style change to follow the suggestions given in
patch reviews for other RATP commands.
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
common/ratp/md.c | 4 ++--
common/ratp/mw.c | 4 ++--
common/ratp/reset.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/ratp/md.c b/common/ratp/md.c
index 9b8fc2bc5..5b877947c 100644
--- a/common/ratp/md.c
+++ b/common/ratp/md.c
@@ -46,7 +46,7 @@ struct ratp_bb_md_request {
uint16_t path_size;
uint16_t path_offset;
uint8_t buffer[];
-} __attribute__((packed));
+} __packed;
struct ratp_bb_md_response {
struct ratp_bb header;
@@ -55,7 +55,7 @@ struct ratp_bb_md_response {
uint16_t data_size;
uint16_t data_offset;
uint8_t buffer[];
-} __attribute__((packed));
+} __packed;
extern char *mem_rw_buf;
diff --git a/common/ratp/mw.c b/common/ratp/mw.c
index 7d6df3d0a..3234d7dac 100644
--- a/common/ratp/mw.c
+++ b/common/ratp/mw.c
@@ -47,7 +47,7 @@ struct ratp_bb_mw_request {
uint16_t data_size;
uint16_t data_offset;
uint8_t buffer[];
-} __attribute__((packed));
+} __packed;
struct ratp_bb_mw_response {
struct ratp_bb header;
@@ -55,7 +55,7 @@ struct ratp_bb_mw_response {
uint32_t errno;
uint16_t written;
uint8_t buffer[];
-} __attribute__((packed));
+} __packed;
static int ratp_cmd_mw(const struct ratp_bb *req, int req_len,
struct ratp_bb **rsp, int *rsp_len)
diff --git a/common/ratp/reset.c b/common/ratp/reset.c
index ca8be4e62..60b6ff536 100644
--- a/common/ratp/reset.c
+++ b/common/ratp/reset.c
@@ -27,7 +27,7 @@
struct ratp_bb_reset {
struct ratp_bb header;
uint8_t force;
-} __attribute__((packed));
+} __packed;
static int ratp_cmd_reset(const struct ratp_bb *req, int req_len,
struct ratp_bb **rsp, int *rsp_len)
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-09-12 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 13:45 [PATCH v2 0/7] RATP i2c and GPIO support Aleksander Morgado
2018-09-12 13:45 ` [PATCH v2 1/7] ratp: implement i2c read/write support Aleksander Morgado
2018-09-12 13:45 ` [PATCH v2 2/7] bbremote: " Aleksander Morgado
2018-09-12 13:45 ` [PATCH v2 3/7] ratp: implement support for GPIO commands Aleksander Morgado
2018-09-12 13:45 ` [PATCH v2 4/7] bbremote: implement support for GPIO operations Aleksander Morgado
2018-09-12 13:45 ` Aleksander Morgado [this message]
2018-09-12 13:45 ` [PATCH v2 6/7] ratp: use pr_ macros to print messages Aleksander Morgado
2018-09-12 13:45 ` [PATCH v2 7/7] ratp: fix incorrect whitespaces in method calls Aleksander Morgado
2018-09-17 7:50 ` [PATCH v2 0/7] RATP i2c and GPIO support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912134550.3970-6-aleksander@aleksander.es \
--to=aleksander@aleksander.es \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox