From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox@lists.infradead.org, Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH for master 1/2] MIPS: fix PCI quirk infrastructure build
Date: Thu, 13 Sep 2018 00:00:05 +0300 [thread overview]
Message-ID: <20180912210006.28087-2-antonynpavlov@gmail.com> (raw)
In-Reply-To: <20180912210006.28087-1-antonynpavlov@gmail.com>
The commit fc2c618c2038 ("pci: add quirk infrastructure")
adds necessary ld-script changes only for ARM architecture.
As a result, qemu-malta build fails:
LD barebox
drivers/built-in.o: In function `pci_fixup_device':
(.text.pci_fixup_device+0x30): undefined reference to `__end_pci_fixups_enable'
(.text.pci_fixup_device+0x38): undefined reference to `__end_pci_fixups_enable'
(.text.pci_fixup_device+0x34): undefined reference to `__start_pci_fixups_enable'
(.text.pci_fixup_device+0x3c): undefined reference to `__start_pci_fixups_enable'
(.text.pci_fixup_device+0x70): undefined reference to `__end_pci_fixups_header'
(.text.pci_fixup_device+0x78): undefined reference to `__end_pci_fixups_header'
(.text.pci_fixup_device+0x74): undefined reference to `__start_pci_fixups_header'
(.text.pci_fixup_device+0x80): undefined reference to `__start_pci_fixups_header'
(.text.pci_fixup_device+0x2c): undefined reference to `__end_pci_fixups_early'
(.text.pci_fixup_device+0x88): undefined reference to `__end_pci_fixups_early'
(.text.pci_fixup_device+0x84): undefined reference to `__start_pci_fixups_early'
(.text.pci_fixup_device+0x90): undefined reference to `__start_pci_fixups_early'
make: *** [Makefile:767: barebox] Error 1
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/lib/barebox.lds.S | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/mips/lib/barebox.lds.S b/arch/mips/lib/barebox.lds.S
index 660d4be85e..c4026bb7f1 100644
--- a/arch/mips/lib/barebox.lds.S
+++ b/arch/mips/lib/barebox.lds.S
@@ -75,6 +75,17 @@ SECTIONS
__usymtab : { BAREBOX_SYMS }
__usymtab_end = .;
+#ifdef CONFIG_PCI
+ __start_pci_fixups_early = .;
+ .pci_fixup_early : { KEEP(*(.pci_fixup_early)) }
+ __end_pci_fixups_early = .;
+ __start_pci_fixups_header = .;
+ .pci_fixup_header : { KEEP(*(.pci_fixup_header)) }
+ __end_pci_fixups_header = .;
+ __start_pci_fixups_enable = .;
+ .pci_fixup_enable : { KEEP(*(.pci_fixup_enable)) }
+ __end_pci_fixups_enable = .;
+#endif
.oftables : { BAREBOX_CLK_TABLE() }
.dtb : { BAREBOX_DTB() }
--
2.18.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-09-12 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 21:00 [PATCH for master 0/2] MIPS and PCI-related fixes Antony Pavlov
2018-09-12 21:00 ` Antony Pavlov [this message]
2018-09-12 21:00 ` [PATCH for master 2/2] pci_of_match_device: don't crash on MIPS Malta Antony Pavlov
2018-09-17 7:32 ` [PATCH for master 0/2] MIPS and PCI-related fixes Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912210006.28087-2-antonynpavlov@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox