* [PATCH] checkpatch: don't check TODO file presence
@ 2018-09-12 21:19 Antony Pavlov
2018-09-17 7:31 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Antony Pavlov @ 2018-09-12 21:19 UTC (permalink / raw)
To: barebox, Sascha Hauer
The commit b3baf2d86149 ("TODO: remove unused file") drops
the TODO file. Alas scripts/checkpatch.pl checks TODO file
presence in top_of_kernel_tree(). Without TODO checkpatch.pl
exits with 'Must be run from the top-level dir. of a kernel tree'.
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 48ad4938d9..9a6f6e2298 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -330,7 +330,7 @@ sub top_of_kernel_tree {
my @tree_check = (
"arch", "commands", "common", "COPYING", "defaultenv",
"Documentation", "drivers", "fs", "include", "lib",
- "MAKEALL", "Makefile", "net", "README", "scripts", "TODO"
+ "MAKEALL", "Makefile", "net", "README", "scripts"
);
foreach my $check (@tree_check) {
--
2.18.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] checkpatch: don't check TODO file presence
2018-09-12 21:19 [PATCH] checkpatch: don't check TODO file presence Antony Pavlov
@ 2018-09-17 7:31 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-09-17 7:31 UTC (permalink / raw)
To: Antony Pavlov; +Cc: barebox
On Thu, Sep 13, 2018 at 12:19:51AM +0300, Antony Pavlov wrote:
> The commit b3baf2d86149 ("TODO: remove unused file") drops
> the TODO file. Alas scripts/checkpatch.pl checks TODO file
> presence in top_of_kernel_tree(). Without TODO checkpatch.pl
> exits with 'Must be run from the top-level dir. of a kernel tree'.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
Applied, thanks
Sascha
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 48ad4938d9..9a6f6e2298 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -330,7 +330,7 @@ sub top_of_kernel_tree {
> my @tree_check = (
> "arch", "commands", "common", "COPYING", "defaultenv",
> "Documentation", "drivers", "fs", "include", "lib",
> - "MAKEALL", "Makefile", "net", "README", "scripts", "TODO"
> + "MAKEALL", "Makefile", "net", "README", "scripts"
> );
>
> foreach my $check (@tree_check) {
> --
> 2.18.0
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 21:19 [PATCH] checkpatch: don't check TODO file presence Antony Pavlov
2018-09-17 7:31 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox