mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: i.MX28: Add APBH clk support
@ 2018-09-17 10:31 Oleksij Rempel
  2018-09-17 11:33 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2018-09-17 10:31 UTC (permalink / raw)
  To: barebox; +Cc: Oleksij Rempel

After this commit iMX28 filed to use DMA and NAND:
|commit 6eb2ba6f1b206bb7d688036a28c98eb4a89be781
|Author: Andrey Smirnov <andrew.smirnov@gmail.com>
|Date:   Sat Mar 31 18:13:57 2018 -0700
|
|dma: apbh: Enable clock as a part of probing
|
|Enable clock as a part of probing in order to avoid problems on SoCs
|that do not have this block ungated out of reset (e.g. i.MX7).
|
|Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

The reason was missing clock base for APBH.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/clk/mxs/clk-imx28.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
index ffe03c8668..dd17a74d79 100644
--- a/drivers/clk/mxs/clk-imx28.c
+++ b/drivers/clk/mxs/clk-imx28.c
@@ -152,6 +152,7 @@ int __init mx28_clocks_init(void __iomem *regs)
 	clkdev_add_physbase(clks[fec], IMX_FEC0_BASE, NULL);
 	clkdev_add_physbase(clks[xbus], IMX_DBGUART_BASE, NULL);
 	clkdev_add_physbase(clks[hbus], IMX_OCOTP_BASE, NULL);
+	clkdev_add_physbase(clks[hbus], MXS_APBH_BASE, NULL);
 	clkdev_add_physbase(clks[uart], IMX_UART0_BASE, NULL);
 	clkdev_add_physbase(clks[uart], IMX_UART1_BASE, NULL);
 	clkdev_add_physbase(clks[uart], IMX_UART2_BASE, NULL);
-- 
2.19.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: i.MX28: Add APBH clk support
  2018-09-17 10:31 [PATCH] ARM: i.MX28: Add APBH clk support Oleksij Rempel
@ 2018-09-17 11:33 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-09-17 11:33 UTC (permalink / raw)
  To: Oleksij Rempel; +Cc: barebox

On Mon, Sep 17, 2018 at 12:31:51PM +0200, Oleksij Rempel wrote:
> After this commit iMX28 filed to use DMA and NAND:
> |commit 6eb2ba6f1b206bb7d688036a28c98eb4a89be781
> |Author: Andrey Smirnov <andrew.smirnov@gmail.com>
> |Date:   Sat Mar 31 18:13:57 2018 -0700
> |
> |dma: apbh: Enable clock as a part of probing
> |
> |Enable clock as a part of probing in order to avoid problems on SoCs
> |that do not have this block ungated out of reset (e.g. i.MX7).
> |
> |Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> |Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> 
> The reason was missing clock base for APBH.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

Applied, thanks

Sascha

>  drivers/clk/mxs/clk-imx28.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
> index ffe03c8668..dd17a74d79 100644
> --- a/drivers/clk/mxs/clk-imx28.c
> +++ b/drivers/clk/mxs/clk-imx28.c
> @@ -152,6 +152,7 @@ int __init mx28_clocks_init(void __iomem *regs)
>  	clkdev_add_physbase(clks[fec], IMX_FEC0_BASE, NULL);
>  	clkdev_add_physbase(clks[xbus], IMX_DBGUART_BASE, NULL);
>  	clkdev_add_physbase(clks[hbus], IMX_OCOTP_BASE, NULL);
> +	clkdev_add_physbase(clks[hbus], MXS_APBH_BASE, NULL);
>  	clkdev_add_physbase(clks[uart], IMX_UART0_BASE, NULL);
>  	clkdev_add_physbase(clks[uart], IMX_UART1_BASE, NULL);
>  	clkdev_add_physbase(clks[uart], IMX_UART2_BASE, NULL);
> -- 
> 2.19.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-17 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 10:31 [PATCH] ARM: i.MX28: Add APBH clk support Oleksij Rempel
2018-09-17 11:33 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox