[PATCH]: ARM/RK3188 radxa-rock sdcard boot env file: DTB location fix

[PATCH]: ARM/RK3188 radxa-rock sdcard boot env file: DTB location fix

[perachet7]

Hi,

As Sascha correctly pointed out, the DTB ought to be specified via a global 
var now.
This patch fixes it.

Boot log was:
[...]
Hit any key to stop autoboot:    1
booting 'mshc1'
mount: No such file or directory
ext4 ext40: EXT2 rev 1, inode_size 128, descriptor size 32
mounted /dev/mshc1.0 on /mnt/mshc1.0
setting root node failed: Device or resource busy
oftree: Device or resource busy

Loading ARM Linux zImage '/mnt/mshc1.0/zImage'
[...]

There still are a couple of issues:

1) mount: No such file or directory [still present]

2) setting root node failed: Device or resource busy

3) oftree: Device or resource busy

Numbers 2) and 3) should be fixed now.

Thx.

S.

diff --git a/arch/arm/boards/radxa-rock/env/boot/mshc1 b/arch/arm/boards/
radxa-rock/env/boot/mshc1
index 7393c4e63..b61dd807d 100644
--- a/arch/arm/boards/radxa-rock/env/boot/mshc1
+++ b/arch/arm/boards/radxa-rock/env/boot/mshc1
@@ -3,7 +3,7 @@
 mount /dev/mshc1.0
 
 global.bootm.boot_atag=true
-oftree -l /mnt/mshc1.0/rk3188-radxarock.dtb
+global.bootm.oftree=/mnt/mshc1.0/rk3188-radxarock.dtb
 
 global.bootm.image=/mnt/mshc1.0/zImage
 global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootwait"




_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH]: ARM/RK3188 radxa-rock sdcard boot env file: DTB location fix

[Sascha Hauer]

Hi,

On Mon, Sep 17, 2018 at 05:41:12PM +0200, perachet7@gmail.com wrote:
> Hi,
> 
> radxa-rock/env/boot/mshc1
> index 7393c4e63..b61dd807d 100644
> --- a/arch/arm/boards/radxa-rock/env/boot/mshc1
> +++ b/arch/arm/boards/radxa-rock/env/boot/mshc1
> @@ -3,7 +3,7 @@
>  mount /dev/mshc1.0
>  
>  global.bootm.boot_atag=true

   ^^^^

This should be removed also since we do not want to boot the board using
ATAGs.

Your patch lacks a Signed-off-by tag. Please add that next time you send
a patch. For this time I created a patch myself with the line above
removed.

Sascha

> -oftree -l /mnt/mshc1.0/rk3188-radxarock.dtb
> +global.bootm.oftree=/mnt/mshc1.0/rk3188-radxarock.dtb
>  
>  global.bootm.image=/mnt/mshc1.0/zImage
>  global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootwait"
> 
> 
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox