From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/8] ARM: nxp-imx8mq-evk: Add FEC's PHY configuration code
Date: Wed, 19 Sep 2018 09:48:44 +0200 [thread overview]
Message-ID: <20180919074844.GN4097@pengutronix.de> (raw)
In-Reply-To: <20180918054148.8878-7-andrew.smirnov@gmail.com>
On Mon, Sep 17, 2018 at 10:41:46PM -0700, Andrey Smirnov wrote:
> Add appropriate DT node and a fixup routine needed for i.MX8MQ EVK
> board.
>
> diff --git a/arch/arm/dts/imx8mq-evk.dts b/arch/arm/dts/imx8mq-evk.dts
> index 3ac13baa1..bdc340a8b 100644
> --- a/arch/arm/dts/imx8mq-evk.dts
> +++ b/arch/arm/dts/imx8mq-evk.dts
> @@ -43,7 +43,18 @@
> <&pinctrl_fec1_data_tx>, <&pinctrl_fec1_data_rx>,
> <&pinctrl_fec1_phy_reset>;
> phy-mode = "rgmii-id";
> + phy-handle = <&fec_phy>;
> + phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fec_phy: ethernet-phy@1 {
> + reg = <1>;
> + };
> + };
What's the reason for adding a phy node here? It shouldn't be needed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-09-19 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 5:41 [PATCH 0/8] i.MX8MQ EVK miscellanea Andrey Smirnov
2018-09-18 5:41 ` [PATCH 1/8] clk: i.MX8MQ: Bump refcounters of various important clocks Andrey Smirnov
2018-09-18 5:41 ` [PATCH 2/8] ARM: i.MX8MQ: Add missing node for ECSPI1 Andrey Smirnov
2018-09-18 5:41 ` [PATCH 3/8] ARM: i.MX8MQ: Configure USDHC1,2 clocks Andrey Smirnov
2018-09-18 5:41 ` [PATCH 4/8] ARM: i.MX8MQ: Configure FEC1 clocks Andrey Smirnov
2018-09-18 5:41 ` [PATCH 5/8] ARM: nxp-imx8mq-evk: Add missing compatibility check Andrey Smirnov
2018-09-18 5:41 ` [PATCH 6/8] ARM: nxp-imx8mq-evk: Add FEC's PHY configuration code Andrey Smirnov
2018-09-19 7:48 ` Sascha Hauer [this message]
2018-09-19 14:57 ` Andrey Smirnov
2018-09-18 5:41 ` [PATCH 7/8] ARM: i.MX: esdctl: Add memory size detection for i.MX8MQ Andrey Smirnov
2018-09-18 5:41 ` [PATCH 8/8] ARM: nxp-imx8mq-evk: Make use of memory size detection code Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919074844.GN4097@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox