From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 1/3] imx-bbu-nand-fcb: Improve error message
Date: Tue, 25 Sep 2018 09:58:45 +0200 [thread overview]
Message-ID: <20180925075847.4585-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20180925075847.4585-1-s.hauer@pengutronix.de>
When printing that a FCB is not readable it's interesting to know which
one is not readable. Print the block number in the message.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/imx-bbu-nand-fcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/imx-bbu-nand-fcb.c b/common/imx-bbu-nand-fcb.c
index 2c8ca97926..5535a92d54 100644
--- a/common/imx-bbu-nand-fcb.c
+++ b/common/imx-bbu-nand-fcb.c
@@ -459,7 +459,7 @@ static int read_fcb(struct mtd_info *mtd, int num, struct fcb_block **retfcb)
fcb = read_fcb_hamming_13_8(rawpage);
if (IS_ERR(fcb)) {
- pr_err("Cannot read fcb\n");
+ pr_err("Cannot read fcb on block %d\n", num);
ret = PTR_ERR(fcb);
goto err;
}
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-09-25 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 7:58 [PATCH 0/3] i.MX6 NAND boot ROM workarounds Sascha Hauer
2018-09-25 7:58 ` Sascha Hauer [this message]
2018-09-25 7:58 ` [PATCH 2/3] imx-bbu-nand-fcb: Workaround ROM not being able to handle bad blocks properly Sascha Hauer
2018-09-25 7:58 ` [PATCH 3/3] imx-bbu-nand-fcb: Workaround ROM checking fingerprint before correcting bitflips Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925075847.4585-2-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox