From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] bbu: command: Make sure specified update handler exists
Date: Thu, 27 Sep 2018 13:42:55 +0200 [thread overview]
Message-ID: <20180927114255.GY4097@pengutronix.de> (raw)
In-Reply-To: <20180927041129.29584-3-andrew.smirnov@gmail.com>
Hi Andrey,
On Wed, Sep 26, 2018 at 09:11:28PM -0700, Andrey Smirnov wrote:
> @@ -57,6 +62,30 @@ static int do_barebox_update(int argc, char *argv[])
> }
> }
>
> + if (data.handler_name && data.devicefile) {
> + printf("Both TARGET and DEVICE are provided. "
> + "Ignoring the latter\n");
> +
> + data.devicefile = NULL;
> + }
> +
> + if (data.handler_name &&
> + !bbu_find_handler_by_name(data.handler_name)) {
> + printf("handler '%s' does not exist\n",
> + data.handler_name);
> + goto error;
> + } else if (data.devicefile &&
> + !bbu_find_handler_by_device(data.devicefile)) {
> + printf("handler for '%s' does not exist\n",
> + data.devicefile);
> + goto error;
> + } if (!data.handler_name &&
> + !data.devicefile &&
> + !bbu_find_handler_by_name(NULL)) {
> + printf("default handler does not exist\n");
> + goto error;
> + }
There should be a linebreak before the last if().
Maybe it should be rewritten as:
if (data.handler_name)
handler = bbu_find_handler_by_name();
else if (data.devicefile)
handler = bbu_find_handler_by_device();
else
handler = bbu_find_handler_by_name();
barebox_update() currently repeats these steps, so I think it would be a
next logical step to pass this handler to barebox_update() instead of
searching it there again.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-09-27 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 4:11 [PATCH 0/3] Additional error checking for barebox_update Andrey Smirnov
2018-09-27 4:11 ` [PATCH 1/3] bbu: Expose bbu_find_handler_by_*() functions Andrey Smirnov
2018-09-27 4:11 ` [PATCH 2/3] bbu: command: Make sure specified update handler exists Andrey Smirnov
2018-09-27 11:42 ` Sascha Hauer [this message]
2018-10-04 20:38 ` Andrey Smirnov
2018-09-27 4:11 ` [PATCH 3/3] bbu: Simplify bbu_find_handler_by_device() Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927114255.GY4097@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox