From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Schenk, Gavin" <G.Schenk@eckelmann.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] usb: gadget: fastboot: fix downoading files of wMaxPacketSize bytes
Date: Mon, 1 Oct 2018 10:37:40 +0200 [thread overview]
Message-ID: <20181001083740.cggmrzwt6jtacyf4@pengutronix.de> (raw)
In-Reply-To: <1c08cd25d72b7f5843b313071a6f040244f0df40.camel@eckelmann.de>
On Mon, Oct 01, 2018 at 08:29:18AM +0000, Schenk, Gavin wrote:
> Hi,
>
> > File transfers with sizes of exact multiples of wMaxPacketSize up to
> > EP_BUFFER_SIZE do not work. For a typical scenario that would be files
> > of 512, 1024 ... 3584 bytes.
> >
> > This happens because we unconditionally put EP_BUFFER_SIZE into the
> > initial request length. For non wMaxPacketSize aligned legths this
> s/legths/length
I'd keep the s at the end though.
Oh, and while we're typo squatting: $Subject ~= s/downoading/downloading
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-10-01 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 8:17 Sascha Hauer
2018-10-01 8:29 ` Schenk, Gavin
2018-10-01 8:37 ` Uwe Kleine-König [this message]
2018-10-01 8:34 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001083740.cggmrzwt6jtacyf4@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=G.Schenk@eckelmann.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox