* [PATCH] e1000/flash: Increased erase timeout
@ 2018-10-01 9:19 Uwe Kleine-König
2018-10-02 6:55 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2018-10-01 9:19 UTC (permalink / raw)
To: barebox; +Cc: Michael Schuhmacher
From: Michael Schuhmacher <m.schuhmacher@eckelmann.de>
Serial flash Adesto AT25DF321A specifies the maximal chip erase time as
40 seconds. Extend timeout accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/net/e1000/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c
index dda022e05437..ffd323106fbb 100644
--- a/drivers/net/e1000/eeprom.c
+++ b/drivers/net/e1000/eeprom.c
@@ -883,7 +883,7 @@ static int e1000_flash_mode_erase_chunk(struct e1000_hw *hw, loff_t offset,
ret = e1000_poll_reg(hw, E1000_FLSWCTL,
E1000_FLSWCTL_DONE | E1000_FLSWCTL_FLBUSY,
E1000_FLSWCTL_DONE,
- 10 * SECOND);
+ 40 * SECOND);
if (ret < 0) {
dev_err(hw->dev,
"Timeout waiting for FLSWCTL.DONE to be set (erase)\n");
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] e1000/flash: Increased erase timeout
2018-10-01 9:19 [PATCH] e1000/flash: Increased erase timeout Uwe Kleine-König
@ 2018-10-02 6:55 ` Sascha Hauer
2018-11-09 9:00 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2018-10-02 6:55 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: barebox, Michael Schuhmacher
On Mon, Oct 01, 2018 at 11:19:07AM +0200, Uwe Kleine-König wrote:
> From: Michael Schuhmacher <m.schuhmacher@eckelmann.de>
>
> Serial flash Adesto AT25DF321A specifies the maximal chip erase time as
> 40 seconds. Extend timeout accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/net/e1000/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c
> index dda022e05437..ffd323106fbb 100644
> --- a/drivers/net/e1000/eeprom.c
> +++ b/drivers/net/e1000/eeprom.c
> @@ -883,7 +883,7 @@ static int e1000_flash_mode_erase_chunk(struct e1000_hw *hw, loff_t offset,
> ret = e1000_poll_reg(hw, E1000_FLSWCTL,
> E1000_FLSWCTL_DONE | E1000_FLSWCTL_FLBUSY,
> E1000_FLSWCTL_DONE,
> - 10 * SECOND);
> + 40 * SECOND);
> if (ret < 0) {
> dev_err(hw->dev,
> "Timeout waiting for FLSWCTL.DONE to be set (erase)\n");
> --
> 2.19.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] e1000/flash: Increased erase timeout
2018-10-02 6:55 ` Sascha Hauer
@ 2018-11-09 9:00 ` Uwe Kleine-König
2018-11-12 7:38 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2018-11-09 9:00 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox, Michael Schuhmacher
Hallo Sascha,
On Tue, Oct 02, 2018 at 08:55:43AM +0200, Sascha Hauer wrote:
> On Mon, Oct 01, 2018 at 11:19:07AM +0200, Uwe Kleine-König wrote:
> > From: Michael Schuhmacher <m.schuhmacher@eckelmann.de>
> >
> > Serial flash Adesto AT25DF321A specifies the maximal chip erase time as
> > 40 seconds. Extend timeout accordingly.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/net/e1000/eeprom.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks
The last patch in next touching drivers/net/e1000/eeprom.c was applied
in July and I cannot find this patch there. What am I missing?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] e1000/flash: Increased erase timeout
2018-11-09 9:00 ` Uwe Kleine-König
@ 2018-11-12 7:38 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2018-11-12 7:38 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: barebox, Michael Schuhmacher
On Fri, Nov 09, 2018 at 10:00:50AM +0100, Uwe Kleine-König wrote:
> Hallo Sascha,
>
> On Tue, Oct 02, 2018 at 08:55:43AM +0200, Sascha Hauer wrote:
> > On Mon, Oct 01, 2018 at 11:19:07AM +0200, Uwe Kleine-König wrote:
> > > From: Michael Schuhmacher <m.schuhmacher@eckelmann.de>
> > >
> > > Serial flash Adesto AT25DF321A specifies the maximal chip erase time as
> > > 40 seconds. Extend timeout accordingly.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > > drivers/net/e1000/eeprom.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Applied, thanks
>
> The last patch in next touching drivers/net/e1000/eeprom.c was applied
> in July and I cannot find this patch there. What am I missing?
Nothing. It was me who missed the patch. Applied now, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-12 7:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 9:19 [PATCH] e1000/flash: Increased erase timeout Uwe Kleine-König
2018-10-02 6:55 ` Sascha Hauer
2018-11-09 9:00 ` Uwe Kleine-König
2018-11-12 7:38 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox