[PATCH] common: state: use of_property_write_string() where appropriate

[PATCH] common: state: use of_property_write_string() where appropriate

[Ulrich Ölmann]

See commit b6089182316d ("treewide: Use of_property_write_string() where
appropriate").

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
 common/state/state_variables.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/common/state/state_variables.c b/common/state/state_variables.c
index de9ba4ab61ac..abd714ceda1e 100644
--- a/common/state/state_variables.c
+++ b/common/state/state_variables.c
@@ -339,8 +339,7 @@ static int state_string_export(struct state_variable *var,
 	int ret = 0;
 
 	if (string->value_default) {
-		ret = of_set_property(node, "default", string->value_default,
-				      strlen(string->value_default) + 1, 1);
+		ret = of_property_write_string(node, "default", string->value_default);
 
 		if (ret)
 			return ret;
@@ -350,8 +349,7 @@ static int state_string_export(struct state_variable *var,
 		return 0;
 
 	if (string->value)
-		ret = of_set_property(node, "value", string->value,
-				      strlen(string->value) + 1, 1);
+		ret = of_property_write_string(node, "value", string->value);
 
 	return ret;
 }
-- 
2.19.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] common: state: use of_property_write_string() where appropriate

[Sascha Hauer]

On Thu, Oct 11, 2018 at 09:13:02AM +0200, Ulrich Ölmann wrote:
> See commit b6089182316d ("treewide: Use of_property_write_string() where
> appropriate").
> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  common/state/state_variables.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/common/state/state_variables.c b/common/state/state_variables.c
> index de9ba4ab61ac..abd714ceda1e 100644
> --- a/common/state/state_variables.c
> +++ b/common/state/state_variables.c
> @@ -339,8 +339,7 @@ static int state_string_export(struct state_variable *var,
>  	int ret = 0;
>  
>  	if (string->value_default) {
> -		ret = of_set_property(node, "default", string->value_default,
> -				      strlen(string->value_default) + 1, 1);
> +		ret = of_property_write_string(node, "default", string->value_default);
>  
>  		if (ret)
>  			return ret;
> @@ -350,8 +349,7 @@ static int state_string_export(struct state_variable *var,
>  		return 0;
>  
>  	if (string->value)
> -		ret = of_set_property(node, "value", string->value,
> -				      strlen(string->value) + 1, 1);
> +		ret = of_property_write_string(node, "value", string->value);
>  
>  	return ret;
>  }
> -- 
> 2.19.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox