mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] miitool: Fix inconsistent spacing
Date: Tue, 16 Oct 2018 08:15:37 +0200	[thread overview]
Message-ID: <20181016061537.p646gcknugzngezq@pengutronix.de> (raw)
In-Reply-To: <20181016003835.11165-1-andrew.smirnov@gmail.com>

On Mon, Oct 15, 2018 at 05:38:35PM -0700, Andrey Smirnov wrote:
> Make sure that there's a space between device name and it's status
> string regardless if if device is using "id" field or not.
> 
> Before:
> 
> barebox@ZII RDU2 Board:/ miitool
> mdio0-phy00: mdio:no link
> mdio1-phy15: 2188000.ethernet@2188000:10 Mbit, half duplex, no link
> mdio1-phy16: 2188000.ethernet@2188000:10 Mbit, half duplex, no link
> mdio2-phy00: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio2-phy01: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio2-phy02: 2188000.ethernet@2188000:mdio:switch@0:negotiated 100baseTx-FD, link ok
> mdio2-phy03: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio2-phy04: 2188000.ethernet@2188000:mdio:switch@0:no link
> mdio3-phy01: eth1: negotiated 1000baseT-FD flow-control, link ok
> 
> After:
> 
> barebox@ZII RDU2 Board:/ miitool
> mdio0-phy00: mdio: no link
> mdio1-phy15: 2188000.ethernet@2188000: 10 Mbit, half duplex, no link
> mdio1-phy16: 2188000.ethernet@2188000: 10 Mbit, half duplex, no link
> mdio2-phy00: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy01: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy02: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy03: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio2-phy04: 2188000.ethernet@2188000:mdio:switch@0: no link
> mdio3-phy01: eth1: no link

the patch seems to have some impact on the link status of mdio2-phy02
and mdio3-phy01. I wonder where this comes from :-)

Other than that:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

because it makes the output better readable.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-16  6:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  0:38 Andrey Smirnov
2018-10-16  6:15 ` Uwe Kleine-König [this message]
2018-10-16  7:06 ` Sascha Hauer
2018-10-27  1:31 [PATCH 0/6] Switch EEPROM aliases to ZII boards Andrey Smirnov
2018-10-27  1:31 ` [PATCH] miitool: Fix inconsistent spacing Andrey Smirnov
2018-10-27  1:34   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016061537.p646gcknugzngezq@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox