From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] net: make routing work after dhcp command
Date: Tue, 16 Oct 2018 08:52:58 +0200 [thread overview]
Message-ID: <20181016065258.xwnuhzcc7v2ldtnb@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqHWfr=Kxqr81ekhMdF_j43eCUNECj+QKSXz_iO3YUKLOQ@mail.gmail.com>
On Mon, Oct 15, 2018 at 07:48:37AM -0700, Andrey Smirnov wrote:
> On Mon, Oct 15, 2018 at 2:26 AM Antony Pavlov <antonynpavlov@gmail.com> wrote:
> >
> > At the moment only ifup stuff turns netif up.
> > After the commit f0624a701513 ('net: Do not route traffic
> > to interfaces that are not up') the dhcp command
> > keeps netif->ifup == false and network subsystem
> > can't route packets.
> >
>
> I am not really trying to make any objections to this patch, however I
> can't seem to find any documented mention that just calling "dhcp" is
> sufficient to bring network up in barebox.
> Documentation/user/networking.rst explicitly tells one to use "ifup"
> for both static and dynamic IP configurations. That being said just
> calling "dhcp" used to work, so this is definitely a regression and it
> might make sense to apply this fix.
Yes, it used to work and it should continue to work, so applied this
one.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-10-16 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 9:26 Antony Pavlov
2018-10-15 14:48 ` Andrey Smirnov
2018-10-16 6:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016065258.xwnuhzcc7v2ldtnb@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox