From: Oleksij Rempel <o.rempel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Subject: [PATCH v1] fs: fix different compile warnings
Date: Tue, 16 Oct 2018 21:42:56 +0200 [thread overview]
Message-ID: <20181016194256.8984-1-o.rempel@pengutronix.de> (raw)
fs/fs.c:96:18: warning: no previous prototype for ‘mntget’ [-Wmissing-prototypes]
struct vfsmount *mntget(struct vfsmount *mnt)
^~~~~~
fs/fs.c:106:6: warning: no previous prototype for ‘mntput’ [-Wmissing-prototypes]
void mntput(struct vfsmount *mnt)
^~~~~~
fs/fs.c:114:18: warning: no previous prototype for ‘lookup_mnt’ [-Wmissing-prototypes]
struct vfsmount *lookup_mnt(struct path *path)
^~~~~~~~~~
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
fs/fs.c | 40 +++++++++++++++++++---------------------
1 file changed, 19 insertions(+), 21 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c
index d76d829140..79ed13cce4 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -93,7 +93,7 @@ static struct fs_device_d *get_fsdevice_by_path(const char *path);
LIST_HEAD(fs_device_list);
-struct vfsmount *mntget(struct vfsmount *mnt)
+static struct vfsmount *mntget(struct vfsmount *mnt)
{
if (!mnt)
return NULL;
@@ -103,7 +103,7 @@ struct vfsmount *mntget(struct vfsmount *mnt)
return mnt;
}
-void mntput(struct vfsmount *mnt)
+static void mntput(struct vfsmount *mnt)
{
if (!mnt)
return;
@@ -111,7 +111,7 @@ void mntput(struct vfsmount *mnt)
mnt->ref--;
}
-struct vfsmount *lookup_mnt(struct path *path)
+static struct vfsmount *lookup_mnt(struct path *path)
{
struct fs_device_d *fsdev;
@@ -181,7 +181,7 @@ static int check_fd(int fd)
return 0;
}
-int create(struct dentry *dir, struct dentry *dentry)
+static int create(struct dentry *dir, struct dentry *dentry)
{
struct inode *inode;
@@ -609,7 +609,7 @@ static int fs_probe(struct device_d *dev)
return 0;
}
-void dentry_kill(struct dentry *dentry)
+static void dentry_kill(struct dentry *dentry)
{
if (dentry->d_inode)
iput(dentry->d_inode);
@@ -622,7 +622,7 @@ void dentry_kill(struct dentry *dentry)
free(dentry);
}
-int dentry_delete_subtree(struct super_block *sb, struct dentry *parent)
+static int dentry_delete_subtree(struct super_block *sb, struct dentry *parent)
{
struct dentry *dentry, *tmp;
@@ -1152,7 +1152,7 @@ void d_set_d_op(struct dentry *dentry, const struct dentry_operations *op)
* available. On a success the dentry is returned. The name passed in is
* copied and the copy passed in may be reused after this call.
*/
-struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
+static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
{
struct dentry *dentry;
@@ -1192,7 +1192,7 @@ struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
* available. On a success the dentry is returned. The name passed in is
* copied and the copy passed in may be reused after this call.
*/
-struct dentry *d_alloc(struct dentry *parent, const struct qstr *name)
+static struct dentry *d_alloc(struct dentry *parent, const struct qstr *name)
{
struct dentry *dentry = __d_alloc(parent->d_sb, name);
if (!dentry)
@@ -1265,7 +1265,8 @@ static bool d_same_name(const struct dentry *dentry,
return strncmp(dentry->d_name.name, name->name, name->len) == 0;
}
-struct dentry *d_lookup(const struct dentry *parent, const struct qstr *name)
+static struct dentry *d_lookup(const struct dentry *parent,
+ const struct qstr *name)
{
struct dentry *dentry;
@@ -1281,10 +1282,6 @@ struct dentry *d_lookup(const struct dentry *parent, const struct qstr *name)
return NULL;
}
-void d_invalidate(struct dentry *dentry)
-{
-}
-
static inline void __d_clear_type_and_inode(struct dentry *dentry)
{
dentry->d_flags &= ~(DCACHE_ENTRY_TYPE | DCACHE_FALLTHRU);
@@ -1358,13 +1355,13 @@ static void set_nameidata(struct nameidata *p, int dfd, struct filename *name)
p->total_link_count = 0;
}
-void path_get(const struct path *path)
+static void path_get(const struct path *path)
{
mntget(path->mnt);
dget(path->dentry);
}
-void path_put(const struct path *path)
+static void path_put(const struct path *path)
{
dput(path->dentry);
mntput(path->mnt);
@@ -1547,7 +1544,7 @@ static int lookup_fast(struct nameidata *nd, struct path *path)
* Return 1 if we went up a level and 0 if we were already at the
* root.
*/
-int follow_up(struct path *path)
+static int follow_up(struct path *path)
{
struct vfsmount *parent, *mnt = path->mnt;
struct dentry *mountpoint;
@@ -1739,7 +1736,7 @@ static int component_len(const char *name, char separator)
return len;
}
-struct filename *getname(const char *filename)
+static struct filename *getname(const char *filename)
{
struct filename *result;
@@ -1758,7 +1755,7 @@ struct filename *getname(const char *filename)
return result;
}
-void putname(struct filename *name)
+static void putname(struct filename *name)
{
BUG_ON(name->refcnt <= 0);
@@ -2105,7 +2102,7 @@ static struct fs_device_d *get_fsdevice_by_path(const char *pathname)
return fsdev;
}
-int vfs_rmdir(struct inode *dir, struct dentry *dentry)
+static int vfs_rmdir(struct inode *dir, struct dentry *dentry)
{
int error;
@@ -2129,7 +2126,7 @@ out:
return error;
}
-int vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
+static int vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
{
int error;
@@ -2388,7 +2385,8 @@ out:
}
EXPORT_SYMBOL(unlink);
-int vfs_symlink(struct inode *dir, struct dentry *dentry, const char *oldname)
+static int vfs_symlink(struct inode *dir, struct dentry *dentry,
+ const char *oldname)
{
if (!dir->i_op->symlink)
return -EPERM;
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2018-10-16 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 19:42 Oleksij Rempel [this message]
2018-10-19 11:59 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016194256.8984-1-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox