From: Roland Hieber <r.hieber@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 2/2] fs/devfs: fix compile warnings
Date: Wed, 17 Oct 2018 11:22:12 +0200 [thread overview]
Message-ID: <20181017092212.3rmxgfffxi3etxfe@pengutronix.de> (raw)
In-Reply-To: <20181016195022.24904-2-o.rempel@pengutronix.de>
For both of these, it would be nice to know what the compiler warnings
were, in case anyone wants to grep the logs.
- Roland
On Tue, Oct 16, 2018 at 09:50:22PM +0200, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> fs/devfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/devfs.c b/fs/devfs.c
> index d2b801036e..10f098280e 100644
> --- a/fs/devfs.c
> +++ b/fs/devfs.c
> @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb)
> return &node->inode;
> }
>
> -int devfs_iterate(struct file *file, struct dir_context *ctx)
> +static int devfs_iterate(struct file *file, struct dir_context *ctx)
> {
> struct cdev *cdev;
>
> --
> 2.19.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Roland Hieber | r.hieber@pengutronix.de |
Pengutronix e.K. | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-10-17 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 19:50 [PATCH v1 1/2] ratp: " Oleksij Rempel
2018-10-16 19:50 ` [PATCH v1 2/2] fs/devfs: " Oleksij Rempel
2018-10-17 9:22 ` Roland Hieber [this message]
2018-10-17 9:44 ` Oleksij Rempel
2018-10-17 9:55 ` Lucas Stach
2018-10-18 6:59 ` [PATCH v1 1/2] ratp: " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017092212.3rmxgfffxi3etxfe@pengutronix.de \
--to=r.hieber@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox