* [PATCH 00/20] Fixes for -Wmissing-prototypes warnings
@ 2018-10-18 6:58 Sascha Hauer
2018-10-18 6:58 ` [PATCH 01/20] ARM: Fix missing prototype warning Sascha Hauer
` (19 more replies)
0 siblings, 20 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
This fixes several warnings that occur with -Wmissing-prototypes enabled.
There are many warnings left to fix, so feel free to continue the work ;)
Sascha
Sascha Hauer (20):
ARM: Fix missing prototype warning
mtd: nand: mxs: make locally used functions static
video: imx-ipu-v3: Make locally used function static
ARM: mmu: rename dma_alloc
dma: Add missing re-inclusion protector
ARM: mmu: include dma.h
fs: Make locally used functions static
ARM: cache: include mmu.h
ARM: boards: GuF Vincell: Make locally used function static
ARM: boards: karo-tx6x: Make locally used function static
ARM: boards: kindle mx50: Make locally used function static
ARM: boards: kontron-samx6i: Add include file to provide prototype
ARM: boards: phytec-som-imx6: Make locally used function static
ARM: legacy Linux support: Make locally used functions static
drivers: clk: imx5: Make locally used functions static
usb: ulpi: Make locally used functions static
ARM: unwind: Provide prototypes for exported functions
ARM: unwind: Make locally used function static
ARM: i.MX: Add missing include
nvmem: i.MX ocotp: Make locally used functions static
arch/arm/boards/guf-vincell/lowlevel.c | 2 +-
arch/arm/boards/karo-tx6x/board.c | 2 +-
arch/arm/boards/kindle-mx50/board.c | 2 +-
arch/arm/boards/kontron-samx6i/board.c | 2 +-
arch/arm/boards/kontron-samx6i/lowlevel.c | 2 +-
arch/arm/boards/kontron-samx6i/mem.c | 2 ++
arch/arm/boards/kontron-samx6i/mem.h | 6 ++++
arch/arm/boards/phytec-som-imx6/board.c | 2 +-
arch/arm/cpu/cache.c | 2 ++
arch/arm/cpu/mmu.c | 7 +++--
arch/arm/include/asm/barebox-arm.h | 2 ++
arch/arm/lib32/armlinux.c | 6 ++--
arch/arm/lib32/unwind.c | 7 ++++-
arch/arm/mach-imx/cpu_init.c | 1 +
drivers/clk/imx/clk-imx5.c | 6 ++--
drivers/mtd/nand/nand_mxs.c | 4 +--
drivers/nvmem/ocotp.c | 4 +--
drivers/usb/otg/ulpi.c | 4 +--
drivers/video/imx-ipu-v3/ipufb.c | 2 +-
fs/fs.c | 36 +++++++++++------------
include/dma-dir.h | 5 ++++
21 files changed, 65 insertions(+), 41 deletions(-)
create mode 100644 arch/arm/boards/kontron-samx6i/mem.h
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 01/20] ARM: Fix missing prototype warning
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 02/20] mtd: nand: mxs: make locally used functions static Sascha Hauer
` (18 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Fixes Warnings in usage of ENTRY_FUNCTION whith -Wmissing-prototypes
enabled:
arch/arm/boards/phytec-som-imx6/lowlevel.c:118:14:
warning: no previous prototype for 'start_phytec_phycore_imx6ul_som_512mb' [-Wmissing-prototypes]
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/include/asm/barebox-arm.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/barebox-arm.h b/arch/arm/include/asm/barebox-arm.h
index bd355f617b..c0c749ae34 100644
--- a/arch/arm/include/asm/barebox-arm.h
+++ b/arch/arm/include/asm/barebox-arm.h
@@ -166,6 +166,8 @@ static inline unsigned long arm_mem_barebox_image(unsigned long membase,
}
#define ENTRY_FUNCTION(name, arg0, arg1, arg2) \
+ void name (uint32_t r0, uint32_t r1, uint32_t r2); \
+ \
static void __##name(uint32_t, uint32_t, uint32_t); \
\
void NAKED __section(.text_head_entry_##name) name \
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 02/20] mtd: nand: mxs: make locally used functions static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
2018-10-18 6:58 ` [PATCH 01/20] ARM: Fix missing prototype warning Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 03/20] video: imx-ipu-v3: Make locally used function static Sascha Hauer
` (17 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mtd/nand/nand_mxs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/nand_mxs.c b/drivers/mtd/nand/nand_mxs.c
index 0e0f5e68b2..28a07d4cba 100644
--- a/drivers/mtd/nand/nand_mxs.c
+++ b/drivers/mtd/nand/nand_mxs.c
@@ -1259,7 +1259,7 @@ static int mxs_nand_scan_bbt(struct mtd_info *mtd)
/*
* Allocate DMA buffers
*/
-int mxs_nand_alloc_buffers(struct mxs_nand_info *nand_info)
+static int mxs_nand_alloc_buffers(struct mxs_nand_info *nand_info)
{
uint8_t *buf;
const int size = NAND_MAX_PAGESIZE + NAND_MAX_OOBSIZE;
@@ -1293,7 +1293,7 @@ int mxs_nand_alloc_buffers(struct mxs_nand_info *nand_info)
/*
* Initializes the NFC hardware.
*/
-int mxs_nand_hw_init(struct mxs_nand_info *info)
+static int mxs_nand_hw_init(struct mxs_nand_info *info)
{
void __iomem *gpmi_regs = info->io_base;
void __iomem *bch_regs = info->bch_base;
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 03/20] video: imx-ipu-v3: Make locally used function static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
2018-10-18 6:58 ` [PATCH 01/20] ARM: Fix missing prototype warning Sascha Hauer
2018-10-18 6:58 ` [PATCH 02/20] mtd: nand: mxs: make locally used functions static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 04/20] ARM: mmu: rename dma_alloc Sascha Hauer
` (16 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/video/imx-ipu-v3/ipufb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/imx-ipu-v3/ipufb.c b/drivers/video/imx-ipu-v3/ipufb.c
index 9597eda0d0..683f298e76 100644
--- a/drivers/video/imx-ipu-v3/ipufb.c
+++ b/drivers/video/imx-ipu-v3/ipufb.c
@@ -101,7 +101,7 @@ static int ipu_crtc_adjust_videomode(struct ipufb_info *fbi, struct fb_videomode
return 0;
}
-int ipu_crtc_mode_set(struct ipufb_info *fbi,
+static int ipu_crtc_mode_set(struct ipufb_info *fbi,
struct fb_videomode *mode,
int x, int y)
{
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 04/20] ARM: mmu: rename dma_alloc
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (2 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 03/20] video: imx-ipu-v3: Make locally used function static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 05/20] dma: Add missing re-inclusion protector Sascha Hauer
` (15 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
a function named dma_alloc is already declared in include/dma.h, so when
we want to include that file we must rename the function.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/cpu/mmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c
index f6c44e3e25..3f00acdb29 100644
--- a/arch/arm/cpu/mmu.c
+++ b/arch/arm/cpu/mmu.c
@@ -497,7 +497,7 @@ void mmu_disable(void)
__mmu_cache_off();
}
-static void *dma_alloc(size_t size, dma_addr_t *dma_handle, unsigned flags)
+static void *dma_alloc_map(size_t size, dma_addr_t *dma_handle, unsigned flags)
{
void *ret;
@@ -515,12 +515,12 @@ static void *dma_alloc(size_t size, dma_addr_t *dma_handle, unsigned flags)
void *dma_alloc_coherent(size_t size, dma_addr_t *dma_handle)
{
- return dma_alloc(size, dma_handle, MAP_UNCACHED);
+ return dma_alloc_map(size, dma_handle, MAP_UNCACHED);
}
void *dma_alloc_writecombine(size_t size, dma_addr_t *dma_handle)
{
- return dma_alloc(size, dma_handle, ARCH_MAP_WRITECOMBINE);
+ return dma_alloc_map(size, dma_handle, ARCH_MAP_WRITECOMBINE);
}
unsigned long virt_to_phys(volatile void *virt)
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 05/20] dma: Add missing re-inclusion protector
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (3 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 04/20] ARM: mmu: rename dma_alloc Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 15:31 ` Sam Ravnborg
2018-10-18 6:58 ` [PATCH 06/20] ARM: mmu: include dma.h Sascha Hauer
` (14 subsequent siblings)
19 siblings, 1 reply; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
include/dma-dir.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/dma-dir.h b/include/dma-dir.h
index ba107f10ce..6e186d8148 100644
--- a/include/dma-dir.h
+++ b/include/dma-dir.h
@@ -1,6 +1,11 @@
+#ifndef __DMA_DIR_H
+#define __DMA_DIR_H
+
enum dma_data_direction {
DMA_BIDIRECTIONAL = 0,
DMA_TO_DEVICE = 1,
DMA_FROM_DEVICE = 2,
DMA_NONE = 3,
};
+
+#endif /* __DMA_DIR_H */
\ No newline at end of file
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 06/20] ARM: mmu: include dma.h
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (4 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 05/20] dma: Add missing re-inclusion protector Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 07/20] fs: Make locally used functions static Sascha Hauer
` (13 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
dma.h provides the prototypes for the different dma_alloc_* functions,
so we should include it to make sure the prototypes are consistent.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/cpu/mmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c
index 3f00acdb29..fc48376f66 100644
--- a/arch/arm/cpu/mmu.c
+++ b/arch/arm/cpu/mmu.c
@@ -19,6 +19,7 @@
#include <common.h>
#include <dma-dir.h>
+#include <dma.h>
#include <init.h>
#include <mmu.h>
#include <errno.h>
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 07/20] fs: Make locally used functions static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (5 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 06/20] ARM: mmu: include dma.h Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 08/20] ARM: cache: include mmu.h Sascha Hauer
` (12 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
fs/fs.c | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c
index d76d829140..899b9d7bc3 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -93,7 +93,7 @@ static struct fs_device_d *get_fsdevice_by_path(const char *path);
LIST_HEAD(fs_device_list);
-struct vfsmount *mntget(struct vfsmount *mnt)
+static struct vfsmount *mntget(struct vfsmount *mnt)
{
if (!mnt)
return NULL;
@@ -103,7 +103,7 @@ struct vfsmount *mntget(struct vfsmount *mnt)
return mnt;
}
-void mntput(struct vfsmount *mnt)
+static void mntput(struct vfsmount *mnt)
{
if (!mnt)
return;
@@ -111,7 +111,7 @@ void mntput(struct vfsmount *mnt)
mnt->ref--;
}
-struct vfsmount *lookup_mnt(struct path *path)
+static struct vfsmount *lookup_mnt(struct path *path)
{
struct fs_device_d *fsdev;
@@ -181,7 +181,7 @@ static int check_fd(int fd)
return 0;
}
-int create(struct dentry *dir, struct dentry *dentry)
+static int create(struct dentry *dir, struct dentry *dentry)
{
struct inode *inode;
@@ -609,7 +609,7 @@ static int fs_probe(struct device_d *dev)
return 0;
}
-void dentry_kill(struct dentry *dentry)
+static void dentry_kill(struct dentry *dentry)
{
if (dentry->d_inode)
iput(dentry->d_inode);
@@ -622,7 +622,7 @@ void dentry_kill(struct dentry *dentry)
free(dentry);
}
-int dentry_delete_subtree(struct super_block *sb, struct dentry *parent)
+static int dentry_delete_subtree(struct super_block *sb, struct dentry *parent)
{
struct dentry *dentry, *tmp;
@@ -1152,7 +1152,7 @@ void d_set_d_op(struct dentry *dentry, const struct dentry_operations *op)
* available. On a success the dentry is returned. The name passed in is
* copied and the copy passed in may be reused after this call.
*/
-struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
+static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
{
struct dentry *dentry;
@@ -1192,7 +1192,7 @@ struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
* available. On a success the dentry is returned. The name passed in is
* copied and the copy passed in may be reused after this call.
*/
-struct dentry *d_alloc(struct dentry *parent, const struct qstr *name)
+static struct dentry *d_alloc(struct dentry *parent, const struct qstr *name)
{
struct dentry *dentry = __d_alloc(parent->d_sb, name);
if (!dentry)
@@ -1265,7 +1265,7 @@ static bool d_same_name(const struct dentry *dentry,
return strncmp(dentry->d_name.name, name->name, name->len) == 0;
}
-struct dentry *d_lookup(const struct dentry *parent, const struct qstr *name)
+static struct dentry *d_lookup(const struct dentry *parent, const struct qstr *name)
{
struct dentry *dentry;
@@ -1281,7 +1281,7 @@ struct dentry *d_lookup(const struct dentry *parent, const struct qstr *name)
return NULL;
}
-void d_invalidate(struct dentry *dentry)
+static void d_invalidate(struct dentry *dentry)
{
}
@@ -1358,13 +1358,13 @@ static void set_nameidata(struct nameidata *p, int dfd, struct filename *name)
p->total_link_count = 0;
}
-void path_get(const struct path *path)
+static void path_get(const struct path *path)
{
mntget(path->mnt);
dget(path->dentry);
}
-void path_put(const struct path *path)
+static void path_put(const struct path *path)
{
dput(path->dentry);
mntput(path->mnt);
@@ -1547,7 +1547,7 @@ static int lookup_fast(struct nameidata *nd, struct path *path)
* Return 1 if we went up a level and 0 if we were already at the
* root.
*/
-int follow_up(struct path *path)
+static int follow_up(struct path *path)
{
struct vfsmount *parent, *mnt = path->mnt;
struct dentry *mountpoint;
@@ -1739,7 +1739,7 @@ static int component_len(const char *name, char separator)
return len;
}
-struct filename *getname(const char *filename)
+static struct filename *getname(const char *filename)
{
struct filename *result;
@@ -1758,7 +1758,7 @@ struct filename *getname(const char *filename)
return result;
}
-void putname(struct filename *name)
+static void putname(struct filename *name)
{
BUG_ON(name->refcnt <= 0);
@@ -2105,7 +2105,7 @@ static struct fs_device_d *get_fsdevice_by_path(const char *pathname)
return fsdev;
}
-int vfs_rmdir(struct inode *dir, struct dentry *dentry)
+static int vfs_rmdir(struct inode *dir, struct dentry *dentry)
{
int error;
@@ -2129,7 +2129,7 @@ out:
return error;
}
-int vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
+static int vfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
{
int error;
@@ -2388,7 +2388,7 @@ out:
}
EXPORT_SYMBOL(unlink);
-int vfs_symlink(struct inode *dir, struct dentry *dentry, const char *oldname)
+static int vfs_symlink(struct inode *dir, struct dentry *dentry, const char *oldname)
{
if (!dir->i_op->symlink)
return -EPERM;
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 08/20] ARM: cache: include mmu.h
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (6 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 07/20] fs: Make locally used functions static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 09/20] ARM: boards: GuF Vincell: Make locally used function static Sascha Hauer
` (11 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
mmu.h provides the prototypes for __mmu_cache_* functions, so include it
from the file that implements these functions.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/cpu/cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/cpu/cache.c b/arch/arm/cpu/cache.c
index f4781fe3b3..e86243db53 100644
--- a/arch/arm/cpu/cache.c
+++ b/arch/arm/cpu/cache.c
@@ -4,6 +4,8 @@
#include <asm/cache.h>
#include <asm/system_info.h>
+#include "mmu.h"
+
struct cache_fns {
void (*dma_clean_range)(unsigned long start, unsigned long end);
void (*dma_flush_range)(unsigned long start, unsigned long end);
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 09/20] ARM: boards: GuF Vincell: Make locally used function static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (7 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 08/20] ARM: cache: include mmu.h Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 10/20] ARM: boards: karo-tx6x: " Sascha Hauer
` (10 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boards/guf-vincell/lowlevel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/guf-vincell/lowlevel.c b/arch/arm/boards/guf-vincell/lowlevel.c
index de706b68b2..0d2216f265 100644
--- a/arch/arm/boards/guf-vincell/lowlevel.c
+++ b/arch/arm/boards/guf-vincell/lowlevel.c
@@ -113,7 +113,7 @@ static void configure_dram_iomux(void)
writel(PAD_CTL_HYS, iomux + IOMUXC_SW_PAD_CTL_GRP_DDRHYS);
}
-void disable_watchdog(void)
+static void disable_watchdog(void)
{
/*
* configure WDOG to generate external reset on trigger
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 10/20] ARM: boards: karo-tx6x: Make locally used function static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (8 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 09/20] ARM: boards: GuF Vincell: Make locally used function static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 11/20] ARM: boards: kindle mx50: " Sascha Hauer
` (9 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boards/karo-tx6x/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/karo-tx6x/board.c b/arch/arm/boards/karo-tx6x/board.c
index 31c1c3a9ff..54b1e248f4 100644
--- a/arch/arm/boards/karo-tx6x/board.c
+++ b/arch/arm/boards/karo-tx6x/board.c
@@ -54,7 +54,7 @@ static struct {
{ 0x33, rn5t567_pmic_setup, "rn5t567" },
};
-int setup_pmic_voltages(void)
+static int setup_pmic_voltages(void)
{
struct i2c_adapter *adapter;
struct i2c_client client;
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 11/20] ARM: boards: kindle mx50: Make locally used function static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (9 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 10/20] ARM: boards: karo-tx6x: " Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 12/20] ARM: boards: kontron-samx6i: Add include file to provide prototype Sascha Hauer
` (8 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boards/kindle-mx50/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/kindle-mx50/board.c b/arch/arm/boards/kindle-mx50/board.c
index 089dd8ebb7..fb1d4c9375 100644
--- a/arch/arm/boards/kindle-mx50/board.c
+++ b/arch/arm/boards/kindle-mx50/board.c
@@ -80,7 +80,7 @@ BAREBOX_MAGICVAR_NAMED(global_atags_revision16, global.board.revision16,
/* The Kindle Kernel expects two custom ATAGs, ATAG_REVISION16 describing
* the board and ATAG_SERIAL16 to identify the individual device.
*/
-struct tag *kindle_mx50_append_atags(struct tag *params)
+static struct tag *kindle_mx50_append_atags(struct tag *params)
{
params = setup_16char_tag(params, ATAG_SERIAL16,
get_env_16char_tag("global.board.serial16"));
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 12/20] ARM: boards: kontron-samx6i: Add include file to provide prototype
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (10 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 11/20] ARM: boards: kindle mx50: " Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 15:33 ` Sam Ravnborg
2018-10-18 6:58 ` [PATCH 13/20] ARM: boards: phytec-som-imx6: Make locally used function static Sascha Hauer
` (7 subsequent siblings)
19 siblings, 1 reply; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
samx6i_get_size() is declared and used in two different C files.
Provide a header file for the prototype instead.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boards/kontron-samx6i/board.c | 2 +-
arch/arm/boards/kontron-samx6i/lowlevel.c | 2 +-
arch/arm/boards/kontron-samx6i/mem.c | 2 ++
arch/arm/boards/kontron-samx6i/mem.h | 6 ++++++
4 files changed, 10 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boards/kontron-samx6i/mem.h
diff --git a/arch/arm/boards/kontron-samx6i/board.c b/arch/arm/boards/kontron-samx6i/board.c
index 01826b67d2..b4b0eac824 100644
--- a/arch/arm/boards/kontron-samx6i/board.c
+++ b/arch/arm/boards/kontron-samx6i/board.c
@@ -23,7 +23,7 @@
#include <asm/armlinux.h>
-resource_size_t samx6i_get_size(void);
+#include "mem.h"
/*
* On this board the SDRAM size is always configured by pin selection.
diff --git a/arch/arm/boards/kontron-samx6i/lowlevel.c b/arch/arm/boards/kontron-samx6i/lowlevel.c
index 5c35007040..9742469e20 100644
--- a/arch/arm/boards/kontron-samx6i/lowlevel.c
+++ b/arch/arm/boards/kontron-samx6i/lowlevel.c
@@ -20,7 +20,7 @@
#include <mach/imx6.h>
#include <mach/esdctl.h>
-resource_size_t samx6i_get_size(void);
+#include "mem.h"
static inline void setup_uart(void)
{
diff --git a/arch/arm/boards/kontron-samx6i/mem.c b/arch/arm/boards/kontron-samx6i/mem.c
index ab9969e32c..3b9fbd464a 100644
--- a/arch/arm/boards/kontron-samx6i/mem.c
+++ b/arch/arm/boards/kontron-samx6i/mem.c
@@ -15,6 +15,8 @@
#include <mach/imx-gpio.h>
#include <mach/imx6.h>
+#include "mem.h"
+
#define PCBVERSION_PIN IMX_GPIO_NR(2, 2)
#define PCBID0_PIN IMX_GPIO_NR(6, 7)
#define PCBID1_PIN IMX_GPIO_NR(6, 9)
diff --git a/arch/arm/boards/kontron-samx6i/mem.h b/arch/arm/boards/kontron-samx6i/mem.h
new file mode 100644
index 0000000000..252b82621d
--- /dev/null
+++ b/arch/arm/boards/kontron-samx6i/mem.h
@@ -0,0 +1,6 @@
+#ifndef __BOARD_KONTRON_SAMX6I_MEM_H
+#define __BOARD_KONTRON_SAMX6I_MEM_H
+
+resource_size_t samx6i_get_size(void);
+
+#endif /* __BOARD_KONTRON_SAMX6I_MEM_H */
\ No newline at end of file
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 13/20] ARM: boards: phytec-som-imx6: Make locally used function static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (11 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 12/20] ARM: boards: kontron-samx6i: Add include file to provide prototype Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 14/20] ARM: legacy Linux support: Make locally used functions static Sascha Hauer
` (6 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boards/phytec-som-imx6/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
index 34a0fe4183..4079bc9de1 100644
--- a/arch/arm/boards/phytec-som-imx6/board.c
+++ b/arch/arm/boards/phytec-som-imx6/board.c
@@ -97,7 +97,7 @@ static unsigned int get_module_rev(void)
return 16 - val;
}
-int ksz8081_phy_fixup(struct phy_device *phydev)
+static int ksz8081_phy_fixup(struct phy_device *phydev)
{
phy_write(phydev, 0x1f, 0x8190);
phy_write(phydev, 0x16, 0x202);
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 14/20] ARM: legacy Linux support: Make locally used functions static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (12 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 13/20] ARM: boards: phytec-som-imx6: Make locally used function static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 15/20] drivers: clk: imx5: " Sascha Hauer
` (5 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/lib32/armlinux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/lib32/armlinux.c b/arch/arm/lib32/armlinux.c
index 2520fe210c..c970f029c5 100644
--- a/arch/arm/lib32/armlinux.c
+++ b/arch/arm/lib32/armlinux.c
@@ -57,7 +57,7 @@ void armlinux_set_architecture(int architecture)
armlinux_architecture = architecture;
}
-int armlinux_get_architecture(void)
+static int armlinux_get_architecture(void)
{
getenv_uint("armlinux_architecture", &armlinux_architecture);
@@ -70,7 +70,7 @@ void armlinux_set_revision(unsigned int rev)
armlinux_system_rev = rev;
}
-unsigned int armlinux_get_revision(void)
+static unsigned int armlinux_get_revision(void)
{
getenv_uint("armlinux_system_rev", &armlinux_system_rev);
@@ -83,7 +83,7 @@ void armlinux_set_serial(u64 serial)
armlinux_system_serial = serial;
}
-u64 armlinux_get_serial(void)
+static u64 armlinux_get_serial(void)
{
getenv_ull("armlinux_system_serial", &armlinux_system_serial);
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 15/20] drivers: clk: imx5: Make locally used functions static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (13 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 14/20] ARM: legacy Linux support: Make locally used functions static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 16/20] usb: ulpi: " Sascha Hauer
` (4 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/clk/imx/clk-imx5.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/imx/clk-imx5.c b/drivers/clk/imx/clk-imx5.c
index edebd25a38..ae94e07f23 100644
--- a/drivers/clk/imx/clk-imx5.c
+++ b/drivers/clk/imx/clk-imx5.c
@@ -279,7 +279,7 @@ static void mx5_clocks_ipu_init(void __iomem *regs)
clks[IMX5_CLK_IPU_SEL] = imx_clk_mux("ipu_sel", regs + CCM_CBCMR, 6, 2, ipu_sel, ARRAY_SIZE(ipu_sel));
}
-int __init mx50_clocks_init(struct device_d *dev, void __iomem *regs)
+static int __init mx50_clocks_init(struct device_d *dev, void __iomem *regs)
{
clks[IMX5_CLK_PLL1_SW] = imx_clk_pllv2("pll1_sw", "osc",
(void *)MX50_PLL1_BASE_ADDR);
@@ -366,7 +366,7 @@ static void mx51_clocks_ipu_init(void __iomem *regs)
clkdev_add_physbase(clks[IMX5_CLK_IPU_DI1_SEL], MX51_IPU_BASE_ADDR, "di1");
}
-int __init mx51_clocks_init(struct device_d *dev, void __iomem *regs)
+static int __init mx51_clocks_init(struct device_d *dev, void __iomem *regs)
{
clks[IMX5_CLK_PLL1_SW] = imx_clk_pllv2("pll1_sw", "osc", (void *)MX51_PLL1_BASE_ADDR);
clks[IMX5_CLK_PLL2_SW] = imx_clk_pllv2("pll2_sw", "osc", (void *)MX51_PLL2_BASE_ADDR);
@@ -454,7 +454,7 @@ static void mx53_clocks_ipu_init(void __iomem *regs)
clkdev_add_physbase(clks[IMX5_CLK_IPU_DI1_SEL], MX53_IPU_BASE_ADDR, "di1");
}
-int __init mx53_clocks_init(struct device_d *dev, void __iomem *regs)
+static int __init mx53_clocks_init(struct device_d *dev, void __iomem *regs)
{
clks[IMX5_CLK_PLL1_SW] = imx_clk_pllv2("pll1_sw", "osc", (void *)MX53_PLL1_BASE_ADDR);
clks[IMX5_CLK_PLL2_SW] = imx_clk_pllv2("pll2_sw", "osc", (void *)MX53_PLL2_BASE_ADDR);
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 16/20] usb: ulpi: Make locally used functions static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (14 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 15/20] drivers: clk: imx5: " Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 17/20] ARM: unwind: Provide prototypes for exported functions Sascha Hauer
` (3 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/usb/otg/ulpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/otg/ulpi.c b/drivers/usb/otg/ulpi.c
index 6fef5f2522..9bc432fa86 100644
--- a/drivers/usb/otg/ulpi.c
+++ b/drivers/usb/otg/ulpi.c
@@ -164,7 +164,7 @@ static int ulpi_read_id(void __iomem *view, int *vid, int *pid)
return 0;
}
-int ulpi_probe(void __iomem *view)
+static int ulpi_probe(void __iomem *view)
{
int i, j, vid, pid, ret;
@@ -187,7 +187,7 @@ int ulpi_probe(void __iomem *view)
return -ENODEV;
}
-int ulpi_set_vbus(void __iomem *view, int on)
+static int ulpi_set_vbus(void __iomem *view, int on)
{
int ret;
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 17/20] ARM: unwind: Provide prototypes for exported functions
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (15 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 16/20] usb: ulpi: " Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 18/20] ARM: unwind: Make locally used function static Sascha Hauer
` (2 subsequent siblings)
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
__aeabi_unwind_cpp_prx are provided to make the linker happy. To fix
warnings about missing prototypes just provide a prototype in the same
file.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/lib32/unwind.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/lib32/unwind.c b/arch/arm/lib32/unwind.c
index c3dca5b61d..d3e79b5702 100644
--- a/arch/arm/lib32/unwind.c
+++ b/arch/arm/lib32/unwind.c
@@ -4,6 +4,10 @@
#include <asm/unwind.h>
#include <asm/sections.h>
+void __aeabi_unwind_cpp_pr0(void);
+void __aeabi_unwind_cpp_pr1(void);
+void __aeabi_unwind_cpp_pr2(void);
+
/* Dummy functions to avoid linker complaints */
void __aeabi_unwind_cpp_pr0(void)
{
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 18/20] ARM: unwind: Make locally used function static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (16 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 17/20] ARM: unwind: Provide prototypes for exported functions Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 19/20] ARM: i.MX: Add missing include Sascha Hauer
2018-10-18 6:58 ` [PATCH 20/20] nvmem: i.MX ocotp: Make locally used functions static Sascha Hauer
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/lib32/unwind.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/lib32/unwind.c b/arch/arm/lib32/unwind.c
index d3e79b5702..fd4b0b22cb 100644
--- a/arch/arm/lib32/unwind.c
+++ b/arch/arm/lib32/unwind.c
@@ -58,7 +58,8 @@ static inline int is_kernel_text(unsigned long addr)
return 0;
}
-void dump_backtrace_entry(unsigned long where, unsigned long from, unsigned long frame)
+static void dump_backtrace_entry(unsigned long where, unsigned long from,
+ unsigned long frame)
{
#ifdef CONFIG_KALLSYMS
printk("[<%08lx>] (%pS) from [<%08lx>] (%pS)\n", where, (void *)where, from, (void *)from);
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 19/20] ARM: i.MX: Add missing include
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (17 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 18/20] ARM: unwind: Make locally used function static Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
2018-10-18 15:35 ` Sam Ravnborg
2018-10-18 6:58 ` [PATCH 20/20] nvmem: i.MX ocotp: Make locally used functions static Sascha Hauer
19 siblings, 1 reply; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
mach/generic.h provides protypes for functions that mach-imx/cpu_init.c
implements, so include the header file.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/mach-imx/cpu_init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/cpu_init.c b/arch/arm/mach-imx/cpu_init.c
index dfbd5ba6c1..f0d009dfd2 100644
--- a/arch/arm/mach-imx/cpu_init.c
+++ b/arch/arm/mach-imx/cpu_init.c
@@ -15,6 +15,7 @@
#include <asm/barebox-arm-head.h>
#include <asm/errata.h>
#include <linux/types.h>
+#include <mach/generic.h>
#ifdef CONFIG_CPU_32
void imx5_cpu_lowlevel_init(void)
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 20/20] nvmem: i.MX ocotp: Make locally used functions static
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
` (18 preceding siblings ...)
2018-10-18 6:58 ` [PATCH 19/20] ARM: i.MX: Add missing include Sascha Hauer
@ 2018-10-18 6:58 ` Sascha Hauer
19 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-18 6:58 UTC (permalink / raw)
To: Barebox List
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/nvmem/ocotp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
index c2d2982ee1..ba35bef99a 100644
--- a/drivers/nvmem/ocotp.c
+++ b/drivers/nvmem/ocotp.c
@@ -184,7 +184,7 @@ static int fuse_read_addr(struct ocotp_priv *priv, u32 addr, u32 *pdata)
return 0;
}
-int imx6_ocotp_read_one_u32(struct ocotp_priv *priv, u32 index, u32 *pdata)
+static int imx6_ocotp_read_one_u32(struct ocotp_priv *priv, u32 index, u32 *pdata)
{
int ret;
@@ -257,7 +257,7 @@ static int imx6_ocotp_reload_shadow(struct ocotp_priv *priv)
return imx6_ocotp_wait_busy(priv, OCOTP_CTRL_RELOAD_SHADOWS);
}
-int imx6_ocotp_blow_one_u32(struct ocotp_priv *priv, u32 index, u32 data,
+static int imx6_ocotp_blow_one_u32(struct ocotp_priv *priv, u32 index, u32 data,
u32 *pfused_value)
{
int ret;
--
2.19.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 05/20] dma: Add missing re-inclusion protector
2018-10-18 6:58 ` [PATCH 05/20] dma: Add missing re-inclusion protector Sascha Hauer
@ 2018-10-18 15:31 ` Sam Ravnborg
0 siblings, 0 replies; 25+ messages in thread
From: Sam Ravnborg @ 2018-10-18 15:31 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Barebox List
On Thu, Oct 18, 2018 at 08:58:12AM +0200, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> include/dma-dir.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/dma-dir.h b/include/dma-dir.h
> index ba107f10ce..6e186d8148 100644
> --- a/include/dma-dir.h
> +++ b/include/dma-dir.h
> @@ -1,6 +1,11 @@
> +#ifndef __DMA_DIR_H
> +#define __DMA_DIR_H
> +
> enum dma_data_direction {
> DMA_BIDIRECTIONAL = 0,
> DMA_TO_DEVICE = 1,
> DMA_FROM_DEVICE = 2,
> DMA_NONE = 3,
> };
> +
> +#endif /* __DMA_DIR_H */
> \ No newline at end of file
Add the missing newline?
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 12/20] ARM: boards: kontron-samx6i: Add include file to provide prototype
2018-10-18 6:58 ` [PATCH 12/20] ARM: boards: kontron-samx6i: Add include file to provide prototype Sascha Hauer
@ 2018-10-18 15:33 ` Sam Ravnborg
0 siblings, 0 replies; 25+ messages in thread
From: Sam Ravnborg @ 2018-10-18 15:33 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Barebox List
On Thu, Oct 18, 2018 at 08:58:19AM +0200, Sascha Hauer wrote:
> samx6i_get_size() is declared and used in two different C files.
> Provide a header file for the prototype instead.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> index ab9969e32c..3b9fbd464a 100644
> --- a/arch/arm/boards/kontron-samx6i/mem.c
> +++ b/arch/arm/boards/kontron-samx6i/mem.c
> @@ -15,6 +15,8 @@
> #include <mach/imx-gpio.h>
> #include <mach/imx6.h>
>
> +#include "mem.h"
> +
> #define PCBVERSION_PIN IMX_GPIO_NR(2, 2)
> #define PCBID0_PIN IMX_GPIO_NR(6, 7)
> #define PCBID1_PIN IMX_GPIO_NR(6, 9)
> diff --git a/arch/arm/boards/kontron-samx6i/mem.h b/arch/arm/boards/kontron-samx6i/mem.h
> new file mode 100644
> index 0000000000..252b82621d
> --- /dev/null
> +++ b/arch/arm/boards/kontron-samx6i/mem.h
> @@ -0,0 +1,6 @@
> +#ifndef __BOARD_KONTRON_SAMX6I_MEM_H
> +#define __BOARD_KONTRON_SAMX6I_MEM_H
> +
> +resource_size_t samx6i_get_size(void);
> +
> +#endif /* __BOARD_KONTRON_SAMX6I_MEM_H */
> \ No newline at end of file
Add missing newline?
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 19/20] ARM: i.MX: Add missing include
2018-10-18 6:58 ` [PATCH 19/20] ARM: i.MX: Add missing include Sascha Hauer
@ 2018-10-18 15:35 ` Sam Ravnborg
2018-10-19 11:51 ` Sascha Hauer
0 siblings, 1 reply; 25+ messages in thread
From: Sam Ravnborg @ 2018-10-18 15:35 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Barebox List
Hi Sasha.
While I am in nitpick mode...
On Thu, Oct 18, 2018 at 08:58:26AM +0200, Sascha Hauer wrote:
> mach/generic.h provides protypes for functions that mach-imx/cpu_init.c
protype => prototypes
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 19/20] ARM: i.MX: Add missing include
2018-10-18 15:35 ` Sam Ravnborg
@ 2018-10-19 11:51 ` Sascha Hauer
0 siblings, 0 replies; 25+ messages in thread
From: Sascha Hauer @ 2018-10-19 11:51 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Barebox List
On Thu, Oct 18, 2018 at 05:35:39PM +0200, Sam Ravnborg wrote:
> Hi Sasha.
>
> While I am in nitpick mode...
>
> On Thu, Oct 18, 2018 at 08:58:26AM +0200, Sascha Hauer wrote:
> > mach/generic.h provides protypes for functions that mach-imx/cpu_init.c
> protype => prototypes
Fixed all, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2018-10-19 11:51 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 6:58 [PATCH 00/20] Fixes for -Wmissing-prototypes warnings Sascha Hauer
2018-10-18 6:58 ` [PATCH 01/20] ARM: Fix missing prototype warning Sascha Hauer
2018-10-18 6:58 ` [PATCH 02/20] mtd: nand: mxs: make locally used functions static Sascha Hauer
2018-10-18 6:58 ` [PATCH 03/20] video: imx-ipu-v3: Make locally used function static Sascha Hauer
2018-10-18 6:58 ` [PATCH 04/20] ARM: mmu: rename dma_alloc Sascha Hauer
2018-10-18 6:58 ` [PATCH 05/20] dma: Add missing re-inclusion protector Sascha Hauer
2018-10-18 15:31 ` Sam Ravnborg
2018-10-18 6:58 ` [PATCH 06/20] ARM: mmu: include dma.h Sascha Hauer
2018-10-18 6:58 ` [PATCH 07/20] fs: Make locally used functions static Sascha Hauer
2018-10-18 6:58 ` [PATCH 08/20] ARM: cache: include mmu.h Sascha Hauer
2018-10-18 6:58 ` [PATCH 09/20] ARM: boards: GuF Vincell: Make locally used function static Sascha Hauer
2018-10-18 6:58 ` [PATCH 10/20] ARM: boards: karo-tx6x: " Sascha Hauer
2018-10-18 6:58 ` [PATCH 11/20] ARM: boards: kindle mx50: " Sascha Hauer
2018-10-18 6:58 ` [PATCH 12/20] ARM: boards: kontron-samx6i: Add include file to provide prototype Sascha Hauer
2018-10-18 15:33 ` Sam Ravnborg
2018-10-18 6:58 ` [PATCH 13/20] ARM: boards: phytec-som-imx6: Make locally used function static Sascha Hauer
2018-10-18 6:58 ` [PATCH 14/20] ARM: legacy Linux support: Make locally used functions static Sascha Hauer
2018-10-18 6:58 ` [PATCH 15/20] drivers: clk: imx5: " Sascha Hauer
2018-10-18 6:58 ` [PATCH 16/20] usb: ulpi: " Sascha Hauer
2018-10-18 6:58 ` [PATCH 17/20] ARM: unwind: Provide prototypes for exported functions Sascha Hauer
2018-10-18 6:58 ` [PATCH 18/20] ARM: unwind: Make locally used function static Sascha Hauer
2018-10-18 6:58 ` [PATCH 19/20] ARM: i.MX: Add missing include Sascha Hauer
2018-10-18 15:35 ` Sam Ravnborg
2018-10-19 11:51 ` Sascha Hauer
2018-10-18 6:58 ` [PATCH 20/20] nvmem: i.MX ocotp: Make locally used functions static Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox