mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] i2c: introduce device_i2c_driver() macro
Date: Thu, 18 Oct 2018 17:51:31 +0200	[thread overview]
Message-ID: <20181018155131.zxnbqgxyu7pb7iob@pengutronix.de> (raw)
In-Reply-To: <20181018154204.GD2206@ravnborg.org>

Hi Sam,

On 18-10-18 17:42, Sam Ravnborg wrote:
> Hi Marco
> 
> > diff --git a/drivers/video/mtl017.c b/drivers/video/mtl017.c
> > index 1a1f686223..085ea110ba 100644
> > --- a/drivers/video/mtl017.c
> > +++ b/drivers/video/mtl017.c
> > @@ -16,7 +16,6 @@
> >   *
> >   */
> >  #include <common.h>
> > -#include <init.h>
> >  #include <driver.h>
> >  #include <xfuncs.h>
> >  #include <errno.h>
> > @@ -270,11 +269,4 @@ static struct driver_d twl_driver = {
> >  	.name  = "mtl017",
> >  	.probe = mtl017_probe,
> >  };
> > -
> > -static int mtl017_init(void)
> > -{
> > -	i2c_driver_register(&twl_driver);
> > -	return 0;
> > -}
> > -
> > -device_initcall(mtl017_init);
> > +device_i2c_driver(twl_driver);
> 
> Not related to your patch, but it looks strange that
> the mtl017 file has a twl_driver.

You're right.

> It looks like a copy-paste issue from the past.

Yes it does and I copy-paste the issue too *argh*
We should fix this by a follow up patch.

Regards,
Marco

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-18 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 10:19 Marco Felsch
2018-10-18 15:42 ` Sam Ravnborg
2018-10-18 15:51   ` Marco Felsch [this message]
2018-10-19 11:54 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018155131.zxnbqgxyu7pb7iob@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox