mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] state: fix indentation
Date: Fri, 19 Oct 2018 13:57:24 +0200	[thread overview]
Message-ID: <20181019115724.e6zpmbzzbhc6tj5e@pengutronix.de> (raw)
In-Reply-To: <20181019044303.537-1-u.oelmann@pengutronix.de>

On Fri, Oct 19, 2018 at 06:43:03AM +0200, Ulrich Ölmann wrote:
> ---
>  common/state/state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/state/state.c b/common/state/state.c
> index bef20210d6e9..54c57232e626 100644
> --- a/common/state/state.c
> +++ b/common/state/state.c
> @@ -311,7 +311,7 @@ static int state_convert_node_variable(struct state *state,
>  		if ((conv == STATE_CONVERT_TO_NODE)
>  		    || (conv == STATE_CONVERT_FIXUP)) {
>  			ret = of_property_write_string(new_node, "type",
> -					      vtype->type_name);
> +						       vtype->type_name);

Patch lacks a signed-off-by. Anyway, it's hardly worth fixing this I
think.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-10-19 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19  4:43 Ulrich Ölmann
2018-10-19 11:57 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019115724.e6zpmbzzbhc6tj5e@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.oelmann@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox