[PATCH v1] Makefile: move -Wmissing-prototypes from mips to main Makefile

[PATCH v1] Makefile: move -Wmissing-prototypes from mips to main Makefile

[Oleksij Rempel]

Currently we get -Wmissing-prototypes warning only on arch/mips.
With this patch we should be able to see this warning on all supported
architectures.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Makefile           | 2 +-
 arch/mips/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 70d501ba5e..fa2020a07d 100644
--- a/Makefile
+++ b/Makefile
@@ -306,7 +306,7 @@ LINUXINCLUDE    := -Iinclude -I$(srctree)/dts/include \
 CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
-                   -Werror-implicit-function-declaration \
+                   -Werror-implicit-function-declaration -Wmissing-prototypes \
                    -fno-strict-aliasing -fno-common -Os -pipe
 AFLAGS          := -D__ASSEMBLY__
 
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 3342e0eafd..6338dc174d 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -12,7 +12,7 @@ endif
 CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants
 
 cflags-y += -G 0 -mno-abicalls -fno-pic -pipe
-cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \
+cflags-y += -Wall -Wstrict-prototypes \
 	-Wno-uninitialized -Wno-format -Wno-main
 
 ifdef CONFIG_32BIT
-- 
2.19.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v1] Makefile: move -Wmissing-prototypes from mips to main Makefile

[Sascha Hauer]

On Wed, Oct 17, 2018 at 04:08:49PM +0200, Oleksij Rempel wrote:
> Currently we get -Wmissing-prototypes warning only on arch/mips.
> With this patch we should be able to see this warning on all supported
> architectures.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Generally I like this. However, there are *so* many warnings on other
architectures that I would prefer fixing another bunch of them before
merging this change.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox