From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFzD9-0003Tt-I6 for barebox@lists.infradead.org; Fri, 26 Oct 2018 10:19:25 +0000 Date: Fri, 26 Oct 2018 12:19:11 +0200 From: Sascha Hauer Message-ID: <20181026101911.kevwudaie33atekk@pengutronix.de> References: <20181025223718.GA24844@lenoch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181025223718.GA24844@lenoch> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] usbgadget: autostart: add DFU support To: Ladislav Michl Cc: barebox@lists.infradead.org Hi Ladis, On Fri, Oct 26, 2018 at 12:37:19AM +0200, Ladislav Michl wrote: > Use global variable dfu_function to autostart DFU. As similar code > is used to start multifunction gadget using command, move common > code to common/usbgadget.c and consolidate it. > > Signed-off-by: Ladislav Michl > --- > This is a draft, comments welcome. Getting > Cannot set parameter otg.mode: No such device I just sent a fix for this. > but that's same as before this patch. Documentation is probably > also worth updating... Indeed. > diff --git a/commands/usbgadget.c b/commands/usbgadget.c > index a1744cbe1..416b2acfc 100644 > --- a/commands/usbgadget.c > +++ b/commands/usbgadget.c > @@ -30,14 +30,18 @@ > #include > #include > > +int usbgadget_register(bool dfu_set, const char *dfu_opts, > + bool fastboot_set, const char *fastboot_opts, > + bool create_serial, bool is_acm, bool export_bbu); > + This should get a prototype somewhere in include/, but that's probably due to the draft status of this patch. Otherwise looks fine to me. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox