From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG017-0001dm-91 for barebox@lists.infradead.org; Fri, 26 Oct 2018 11:11:03 +0000 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23992869AbeJZLKshStml (ORCPT ); Fri, 26 Oct 2018 13:10:48 +0200 Date: Fri, 26 Oct 2018 13:10:47 +0200 From: Ladislav Michl Message-ID: <20181026111047.GA4216@lenoch> References: <20181025223718.GA24844@lenoch> <20181026101911.kevwudaie33atekk@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181026101911.kevwudaie33atekk@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] usbgadget: autostart: add DFU support To: Sascha Hauer Cc: barebox@lists.infradead.org On Fri, Oct 26, 2018 at 12:19:11PM +0200, Sascha Hauer wrote: > Hi Ladis, > > On Fri, Oct 26, 2018 at 12:37:19AM +0200, Ladislav Michl wrote: > > Use global variable dfu_function to autostart DFU. As similar code > > is used to start multifunction gadget using command, move common > > code to common/usbgadget.c and consolidate it. > > > > Signed-off-by: Ladislav Michl > > --- > > This is a draft, comments welcome. Getting > > Cannot set parameter otg.mode: No such device > > I just sent a fix for this. Thanks, tested, added. > > but that's same as before this patch. Documentation is probably > > also worth updating... > > Indeed. Will add prepatch to document bbu then. > > diff --git a/commands/usbgadget.c b/commands/usbgadget.c > > index a1744cbe1..416b2acfc 100644 > > --- a/commands/usbgadget.c > > +++ b/commands/usbgadget.c > > @@ -30,14 +30,18 @@ > > #include > > #include > > > > +int usbgadget_register(bool dfu_set, const char *dfu_opts, > > + bool fastboot_set, const char *fastboot_opts, > > + bool create_serial, bool is_acm, bool export_bbu); > > + > > This should get a prototype somewhere in include/, but that's probably > due to the draft status of this patch. Any idea where would it fit? Or just create new file (which seems overkill to me)? > Otherwise looks fine to me. usbgadget takes -s switch to create serial gadget and -a to create acm. However I fail to see how is creating former done. ladis _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox