From: Ladislav Michl <ladis@linux-mips.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] usbgadget: autostart: add DFU support
Date: Fri, 26 Oct 2018 15:54:40 +0200 [thread overview]
Message-ID: <20181026135440.GA6997@lenoch> (raw)
In-Reply-To: <20181026113156.ldj7twmzwd2deaxi@pengutronix.de>
On Fri, Oct 26, 2018 at 01:31:56PM +0200, Sascha Hauer wrote:
> On Fri, Oct 26, 2018 at 01:10:47PM +0200, Ladislav Michl wrote:
> > usbgadget takes -s switch to create serial gadget and -a to create acm.
> > However I fail to see how is creating former done.
>
> To be honest I always use acm and never found out how the generic serial
> works. It may have bitrotted over time, but for me it never worked.
Fair enough then. I do not even see support for it in the initial commit,
which introduces '-s' switch. I suggest removing it altogether, perhaps
with an option to silently fall back to create ACM as well. ACM is so
common, that using anything else for this (console) purpose is probably
unwise anyway. Objections?
ladis
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-10-26 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 22:37 Ladislav Michl
2018-10-26 10:19 ` Sascha Hauer
2018-10-26 11:10 ` Ladislav Michl
2018-10-26 11:31 ` Sascha Hauer
2018-10-26 13:54 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026135440.GA6997@lenoch \
--to=ladis@linux-mips.org \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox