mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 10/11] VF610: zii-vf610-dev: Replace board code with gpio-hog nodes
Date: Mon, 29 Oct 2018 12:13:42 +0100	[thread overview]
Message-ID: <20181029111342.ne4lrurwgmmmboav@pengutronix.de> (raw)
In-Reply-To: <20181027013157.23135-11-andrew.smirnov@gmail.com>

On Fri, Oct 26, 2018 at 06:31:56PM -0700, Andrey Smirnov wrote:
> diff --git a/arch/arm/dts/vf610-zii-cfu1.dts b/arch/arm/dts/vf610-zii-cfu1.dts
> index 149333596..74ec9fd1d 100644
> --- a/arch/arm/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/dts/vf610-zii-cfu1.dts
> @@ -19,3 +19,28 @@
>  	};
>  };
>  
> +
> +&gpio3 {
> +	fim-tdis {
> +		gpio-hog;
> +		gpios = <22 GPIO_ACTIVE_HIGH>;
> +		output-low;
> +		line-name = "fim_tdis";
> +	};
> +
> +	e6352-intn {
> +		gpio-hog;
> +		gpios = <2 GPIO_ACTIVE_HIGH>;
> +		input;
> +		line-name = "e6352_intn";
> +	};
> +};
> +
> +&gpio4 {
> +	fim-sd {
> +		gpio-hog;
> +		gpios = <4 GPIO_ACTIVE_HIGH>;
> +		input;
> +		line-name = "fim_sd";
> +	};
> +};

Hog GPIOs are GPIOs that are initialized once in the Kernel and from
then on can never be changed. Is this true for these GPIOs you change
here? I just want to make sure that you do not use gpio-hog in barebox
to configure it and do something different in the Kernel because you
pass another devicetree to the kernel. Or, to put it differently, you
should be able to pass the barebox devicetree to Linux and still have
a fully operating system.

If that is true then I can apply these patches. Otherwise I would prefer
some gpio-init mechanism that is implemented in barebox and the Kernel
just don't cares.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-29 11:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27  1:31 [PATCH 00/11] Allow GPIOs to be referenced by label Andrey Smirnov
2018-10-27  1:31 ` [PATCH 01/11] gpio: VF610: Propagate error code of gpiochip_add() up Andrey Smirnov
2018-10-27  1:31 ` [PATCH 02/11] VF610: Initialize pinctrl driver before gpio Andrey Smirnov
2018-10-27  1:31 ` [PATCH 03/11] linux/ctype.h: Port _tolower() Andrey Smirnov
2018-10-27  1:31 ` [PATCH 04/11] lib: Port kstrtox.c from Linux kernel Andrey Smirnov
2018-10-27  1:31 ` [PATCH 05/11] commands: gpio: Move argument parsing into a shared function Andrey Smirnov
2018-10-27  1:31 ` [PATCH 06/11] commands: gpio: Use kstrtoint() instead of simple_strtoul() Andrey Smirnov
2018-10-27  1:31 ` [PATCH 07/11] gpiolib: Introduce gpio_find_by_label() Andrey Smirnov
2018-10-27  1:31 ` [PATCH 08/11] commands: gpio: Allow GPIOs to be specified by label Andrey Smirnov
2018-10-27  1:31 ` [PATCH 09/11] VF610: zii-vf610-dev: Drop switch reset GPIO configuration Andrey Smirnov
2018-10-27  1:31 ` [PATCH 10/11] VF610: zii-vf610-dev: Replace board code with gpio-hog nodes Andrey Smirnov
2018-10-29 11:13   ` Sascha Hauer [this message]
2018-10-29 17:14     ` Andrey Smirnov
2018-10-27  1:31 ` [PATCH 11/11] ARM: rdu2: " Andrey Smirnov
2018-11-05 16:25   ` Andrey Smirnov
2018-11-06  8:25     ` Sascha Hauer
2018-10-27  8:42 ` [PATCH 00/11] Allow GPIOs to be referenced by label Sam Ravnborg
2018-10-29 11:17   ` Sascha Hauer
2018-10-29 11:14 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029111342.ne4lrurwgmmmboav@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox