mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] of: unflatten: access property properly
@ 2018-10-30  7:30 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2018-10-30  7:30 UTC (permalink / raw)
  To: Barebox List

Properties have to be accessed with of_property_get_value() rather than
accessing them directly from the devicenode. The accessor does the
right thing when of_new_property_const() is used.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/of/fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 92dd86e4ec..cf3f1ee147 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -227,7 +227,7 @@ static struct device_node *__of_unflatten_dtb(const void *infdt, bool constprops
 				p = of_new_property(node, name, nodep, len);
 
 			if (!strcmp(name, "phandle") && len == 4)
-				node->phandle = be32_to_cpup(p->value);
+				node->phandle = be32_to_cpup(of_property_get_value(p));
 
 			dt_struct = dt_struct_advance(&f, dt_struct,
 					sizeof(struct fdt_property) + len);
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-10-30  7:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30  7:30 [PATCH] of: unflatten: access property properly Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox