[PATCH] mmc: atmel: Make write work on sama5d3

[PATCH] mmc: atmel: Make write work on sama5d3

[Sascha Hauer]

For some reason the sama5d3 needs a delay after a
MMC_CMD_STOP_TRANSMISSION command. Without it writing fails with:

ERROR: atmel_mci f0000000.mmc@f0000000: command/data timeout
ERROR: atmel_mci f0000000.mmc@f0000000: command/data timeout

The reason is not yet clear, so live with this hack for now.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mci/atmel_mci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mci/atmel_mci.c b/drivers/mci/atmel_mci.c
index 0d3b245ced..122d999087 100644
--- a/drivers/mci/atmel_mci.c
+++ b/drivers/mci/atmel_mci.c
@@ -468,6 +468,10 @@ static int atmci_request(struct mci_host *mci, struct mci_cmd *cmd, struct mci_d
 	}
 
 	stat = atmci_poll_status(host, ATMCI_CMDRDY);
+
+	if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION)
+		mdelay(5);
+
 	return atmci_cmd_done(host, stat);
 }
 
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] mmc: atmel: Make write work on sama5d3

[Sascha Hauer]

On Fri, Nov 02, 2018 at 10:11:56AM +0100, Sascha Hauer wrote:
> For some reason the sama5d3 needs a delay after a
> MMC_CMD_STOP_TRANSMISSION command. Without it writing fails with:
> 
> ERROR: atmel_mci f0000000.mmc@f0000000: command/data timeout
> ERROR: atmel_mci f0000000.mmc@f0000000: command/data timeout
> 
> The reason is not yet clear, so live with this hack for now.

I won't apply this one, just want to have that noted somewhere. If
anyone has an idea please tell me, I am clueless :(

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] mmc: atmel: Make write work on sama5d3

[Ahmad Fatoum]

On 02.11.18 10:14, Sascha Hauer wrote:
> On Fri, Nov 02, 2018 at 10:11:56AM +0100, Sascha Hauer wrote:
>> For some reason the sama5d3 needs a delay after a
>> MMC_CMD_STOP_TRANSMISSION command. Without it writing fails with:
>>
>> ERROR: atmel_mci f0000000.mmc@f0000000: command/data timeout
>> ERROR: atmel_mci f0000000.mmc@f0000000: command/data timeout
>>
>> The reason is not yet clear, so live with this hack for now.
> 
> I won't apply this one, just want to have that noted somewhere. If
> anyone has an idea please tell me, I am clueless :(

Issue still persists with SAMA5D4. I just sent a patch, which I think
may be a proper fix for this issue.

Cheers,
Ahmad

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |