mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 20/20] Make: Add -Wmissing-prototypes
Date: Fri,  9 Nov 2018 10:52:46 +0100	[thread overview]
Message-ID: <20181109095246.15068-21-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20181109095246.15068-1-s.hauer@pengutronix.de>

-Wmissing-prototypes is a useful warning, so add it to the build.

With this we can detect conflicting function prototypes. When a file
implements a function but doesn't include the header file which
provides the prototype for it then conflicting prototypes would go
unnoticed without this warning.

MIPS already had that warning, so we can remove it from the MIPS
Makefile.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 Makefile           | 2 +-
 arch/mips/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index db474af502..203ae20e7e 100644
--- a/Makefile
+++ b/Makefile
@@ -307,7 +307,7 @@ CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffre
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
                    -Werror-implicit-function-declaration \
-                   -fno-strict-aliasing -fno-common -Os -pipe
+                   -fno-strict-aliasing -fno-common -Os -pipe -Wmissing-prototypes
 AFLAGS          := -D__ASSEMBLY__
 
 LDFLAGS_barebox	:= -Map barebox.map
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 3342e0eafd..6338dc174d 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -12,7 +12,7 @@ endif
 CPPFLAGS += -D__MIPS__ -fno-strict-aliasing -fno-merge-constants
 
 cflags-y += -G 0 -mno-abicalls -fno-pic -pipe
-cflags-y += -Wall -Wmissing-prototypes -Wstrict-prototypes \
+cflags-y += -Wall -Wstrict-prototypes \
 	-Wno-uninitialized -Wno-format -Wno-main
 
 ifdef CONFIG_32BIT
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2018-11-09  9:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09  9:52 [PATCH 00/20] Fix another ton of missing prototype warnings Sascha Hauer
2018-11-09  9:52 ` [PATCH 01/20] ARM: interrupts: Avoid missing prototypes warning Sascha Hauer
2018-11-09  9:52 ` [PATCH 02/20] ARM: psci: " Sascha Hauer
2018-11-09  9:52 ` [PATCH 03/20] gui: lodepng: " Sascha Hauer
2018-11-09  9:52 ` [PATCH 04/20] ARM: sm: Make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 05/20] fs: ubifs: Avoid missing prototype warning Sascha Hauer
2018-11-09  9:52 ` [PATCH 06/20] ARM: start: Add missing include Sascha Hauer
2018-11-09  9:52 ` [PATCH 07/20] ARM: start: Add missing prototype Sascha Hauer
2018-11-09  9:52 ` [PATCH 08/20] ARM: Add missing prototype for arm_mem_ramoops_get() Sascha Hauer
2018-11-09  9:52 ` [PATCH 09/20] ARM: i.MX50: Make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 10/20] ARM: i.MX27: Add missing prototype for imx27_get_boot_source() Sascha Hauer
2018-11-09  9:52 ` [PATCH 11/20] ARM: i.MX: add missing include Sascha Hauer
2018-11-09  9:52 ` [PATCH 12/20] ARM: i.MX6 usb: Add " Sascha Hauer
2018-11-09  9:52 ` [PATCH 13/20] imx-bbu-nand: Make locally used functions static Sascha Hauer
2018-11-09  9:52 ` [PATCH 14/20] clk: imx: Avoid missing prototype warnings Sascha Hauer
2018-11-09  9:52 ` [PATCH 15/20] dma: apbh: make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 16/20] pinctrl: at91: Add missing include Sascha Hauer
2018-11-09  9:52 ` [PATCH 17/20] video: vpl: make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 18/20] fs: devfs: Make " Sascha Hauer
2018-11-09  9:52 ` [PATCH 19/20] nvmem: Add prototype for exported functions Sascha Hauer
2018-11-09  9:52 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109095246.15068-21-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox