mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 03/20] gui: lodepng: Avoid missing prototypes warning
Date: Fri,  9 Nov 2018 10:52:29 +0100	[thread overview]
Message-ID: <20181109095246.15068-4-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20181109095246.15068-1-s.hauer@pengutronix.de>

- move prototypes to header file
- remove some unused functions
- make locally used functions static.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 lib/gui/lodepng.c | 42 +-----------------------------------------
 lib/gui/lodepng.h | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 41 deletions(-)

diff --git a/lib/gui/lodepng.c b/lib/gui/lodepng.c
index ba21cd235f..9cc59d7097 100644
--- a/lib/gui/lodepng.c
+++ b/lib/gui/lodepng.c
@@ -74,34 +74,6 @@ static void myfree(void* ptr)
   free(ptr);
 }
 
-/*
-Declaration of the custom functions used if LODEPNG_COMPILE_ZLIB isn't defined
-or LODEPNG_CUSTOM_ZLIB_DECODER or LODEPNG_CUSTOM_ZLIB_ENCODER are enabled.
-
-In that case, you need to define these yourself (which you can do in one of your
-own source files) so that LodePNG can link to it.
-
-By default, this is not needed. If LODEPNG_COMPILE_ZLIB isn't defined, then only
-the two zlib related ones are needed.
-
-If needed, the functions must act as follows:
-*out must be NULL and *outsize must be 0 initially, and after the function is done,
-*out must point to the decompressed data, *outsize must be the size of it, and must
-be the size of the useful data in bytes, not the alloc size.
-*/
-unsigned lodepng_custom_zlib_decompress(unsigned char** out, size_t* outsize,
-                                        const unsigned char* in, size_t insize,
-                                        const LodePNGDecompressSettings* settings);
-unsigned lodepng_custom_zlib_compress(unsigned char** out, size_t* outsize,
-                                      const unsigned char* in, size_t insize,
-                                      const LodePNGCompressSettings* settings);
-unsigned lodepng_custom_inflate(unsigned char** out, size_t* outsize,
-                                const unsigned char* in, size_t insize,
-                                const LodePNGDecompressSettings* settings);
-unsigned lodepng_custom_deflate(unsigned char** out, size_t* outsize,
-                                const unsigned char* in, size_t insize,
-                                const LodePNGCompressSettings* settings);
-
 /* ////////////////////////////////////////////////////////////////////////// */
 /* ////////////////////////////////////////////////////////////////////////// */
 /* // Tools for C, and common code for PNG and Zlib.                       // */
@@ -348,7 +320,7 @@ static void string_set(char** out, const char* in)
 
 /* ////////////////////////////////////////////////////////////////////////// */
 
-unsigned lodepng_read32bitInt(const unsigned char* buffer)
+static unsigned lodepng_read32bitInt(const unsigned char* buffer)
 {
   return (buffer[0] << 24) | (buffer[1] << 16) | (buffer[2] << 8) | buffer[3];
 }
@@ -2668,11 +2640,6 @@ size_t lodepng_get_raw_size(unsigned w, unsigned h, const LodePNGColorMode* colo
   return (w * h * lodepng_get_bpp(color) + 7) / 8;
 }
 
-size_t lodepng_get_raw_size_lct(unsigned w, unsigned h, LodePNGColorType colortype, unsigned bitdepth)
-{
-  return (w * h * lodepng_get_bpp_lct(colortype, bitdepth) + 7) / 8;
-}
-
 #ifdef LODEPNG_COMPILE_ANCILLARY_CHUNKS
 
 static void LodePNGUnknownChunks_init(LodePNGInfo* info)
@@ -2906,13 +2873,6 @@ unsigned lodepng_info_copy(LodePNGInfo* dest, const LodePNGInfo* source)
   return 0;
 }
 
-void lodepng_info_swap(LodePNGInfo* a, LodePNGInfo* b)
-{
-  LodePNGInfo temp = *a;
-  *a = *b;
-  *b = temp;
-}
-
 /* ////////////////////////////////////////////////////////////////////////// */
 
 /*index: bitgroup index, bits: bitgroup size(1, 2 or 4, in: bitgroup value, out: octet array to add bits to*/
diff --git a/lib/gui/lodepng.h b/lib/gui/lodepng.h
index 50d5303055..7f636f0a73 100644
--- a/lib/gui/lodepng.h
+++ b/lib/gui/lodepng.h
@@ -855,6 +855,34 @@ unsigned compress(std::vector<unsigned char>& out, const std::vector<unsigned ch
 } //namespace lodepng
 #endif /*LODEPNG_COMPILE_CPP*/
 
+/*
+Declaration of the custom functions used if LODEPNG_COMPILE_ZLIB isn't defined
+or LODEPNG_CUSTOM_ZLIB_DECODER or LODEPNG_CUSTOM_ZLIB_ENCODER are enabled.
+
+In that case, you need to define these yourself (which you can do in one of your
+own source files) so that LodePNG can link to it.
+
+By default, this is not needed. If LODEPNG_COMPILE_ZLIB isn't defined, then only
+the two zlib related ones are needed.
+
+If needed, the functions must act as follows:
+*out must be NULL and *outsize must be 0 initially, and after the function is done,
+*out must point to the decompressed data, *outsize must be the size of it, and must
+be the size of the useful data in bytes, not the alloc size.
+*/
+unsigned lodepng_custom_zlib_decompress(unsigned char** out, size_t* outsize,
+                                        const unsigned char* in, size_t insize,
+                                        const LodePNGDecompressSettings* settings);
+unsigned lodepng_custom_zlib_compress(unsigned char** out, size_t* outsize,
+                                      const unsigned char* in, size_t insize,
+                                      const LodePNGCompressSettings* settings);
+unsigned lodepng_custom_inflate(unsigned char** out, size_t* outsize,
+                                const unsigned char* in, size_t insize,
+                                const LodePNGDecompressSettings* settings);
+unsigned lodepng_custom_deflate(unsigned char** out, size_t* outsize,
+                                const unsigned char* in, size_t insize,
+                                const LodePNGCompressSettings* settings);
+
 /*
 TODO:
 [.] test if there are no memory leaks or security exploits - done a lot but needs to be checked often
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-11-09  9:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09  9:52 [PATCH 00/20] Fix another ton of missing prototype warnings Sascha Hauer
2018-11-09  9:52 ` [PATCH 01/20] ARM: interrupts: Avoid missing prototypes warning Sascha Hauer
2018-11-09  9:52 ` [PATCH 02/20] ARM: psci: " Sascha Hauer
2018-11-09  9:52 ` Sascha Hauer [this message]
2018-11-09  9:52 ` [PATCH 04/20] ARM: sm: Make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 05/20] fs: ubifs: Avoid missing prototype warning Sascha Hauer
2018-11-09  9:52 ` [PATCH 06/20] ARM: start: Add missing include Sascha Hauer
2018-11-09  9:52 ` [PATCH 07/20] ARM: start: Add missing prototype Sascha Hauer
2018-11-09  9:52 ` [PATCH 08/20] ARM: Add missing prototype for arm_mem_ramoops_get() Sascha Hauer
2018-11-09  9:52 ` [PATCH 09/20] ARM: i.MX50: Make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 10/20] ARM: i.MX27: Add missing prototype for imx27_get_boot_source() Sascha Hauer
2018-11-09  9:52 ` [PATCH 11/20] ARM: i.MX: add missing include Sascha Hauer
2018-11-09  9:52 ` [PATCH 12/20] ARM: i.MX6 usb: Add " Sascha Hauer
2018-11-09  9:52 ` [PATCH 13/20] imx-bbu-nand: Make locally used functions static Sascha Hauer
2018-11-09  9:52 ` [PATCH 14/20] clk: imx: Avoid missing prototype warnings Sascha Hauer
2018-11-09  9:52 ` [PATCH 15/20] dma: apbh: make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 16/20] pinctrl: at91: Add missing include Sascha Hauer
2018-11-09  9:52 ` [PATCH 17/20] video: vpl: make locally used function static Sascha Hauer
2018-11-09  9:52 ` [PATCH 18/20] fs: devfs: Make " Sascha Hauer
2018-11-09  9:52 ` [PATCH 19/20] nvmem: Add prototype for exported functions Sascha Hauer
2018-11-09  9:52 ` [PATCH 20/20] Make: Add -Wmissing-prototypes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181109095246.15068-4-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox