Re: [PATCH v1 4/5] clk: imx: cpu: avoid use after free on error

[Sascha Hauer <s.hauer@pengutronix.de>]

On Sat, Nov 10, 2018 at 08:59:53AM +0100, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
>  drivers/clk/imx/clk-cpu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-cpu.c b/drivers/clk/imx/clk-cpu.c
> index 5ac0ed178..f9db36018 100644
> --- a/drivers/clk/imx/clk-cpu.c
> +++ b/drivers/clk/imx/clk-cpu.c
> @@ -111,8 +111,10 @@ struct clk *imx_clk_cpu(const char *name, const char *parent_name,
>  	cpu->clk.num_parents = 1;
>  
>  	ret = clk_register(&cpu->clk);
> -	if (ret)
> +	if (ret) {
>  		free(cpu);
> +		return 0;

Should be return NULL.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox