* [PATCH] ARM: Do not build hyp.S for AArch64
@ 2018-11-15 3:00 Andrey Smirnov
2018-11-15 7:41 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-11-15 3:00 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
This file is only meant for ARMv7 and trying to build it on ARMv8
results in a build break.
Fixes: baa1aec03 ("ARM: allow secure monitor code to be built without PSCI")
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
I feel like this should really be gated by CONFIG_CPU32v7 since I
think the code in question is ARMv7-only, but I am not
sure. Comments/advise are wellcome.
Thanks,
Andrey Smirnov
arch/arm/cpu/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/Makefile b/arch/arm/cpu/Makefile
index 45de2728d..390fa4437 100644
--- a/arch/arm/cpu/Makefile
+++ b/arch/arm/cpu/Makefile
@@ -4,7 +4,7 @@ obj-$(CONFIG_ARM_EXCEPTIONS) += exceptions$(S64).o interrupts$(S64).o
obj-$(CONFIG_MMU) += mmu$(S64).o
lwl-y += lowlevel$(S64).o
obj-pbl-$(CONFIG_MMU) += mmu-early$(S64).o
-obj-pbl-y += hyp.o
+obj-pbl-$(if $(S64),,y) += hyp.o
AFLAGS_hyp.o :=-Wa,-march=armv7-a -Wa,-mcpu=all
AFLAGS_pbl-hyp.o :=-Wa,-march=armv7-a -Wa,-mcpu=all
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: Do not build hyp.S for AArch64
2018-11-15 3:00 [PATCH] ARM: Do not build hyp.S for AArch64 Andrey Smirnov
@ 2018-11-15 7:41 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-11-15 7:41 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Wed, Nov 14, 2018 at 07:00:24PM -0800, Andrey Smirnov wrote:
> This file is only meant for ARMv7 and trying to build it on ARMv8
> results in a build break.
>
> Fixes: baa1aec03 ("ARM: allow secure monitor code to be built without PSCI")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>
> I feel like this should really be gated by CONFIG_CPU32v7 since I
> think the code in question is ARMv7-only, but I am not
> sure. Comments/advise are wellcome.
Please rebase. Current master has
obj-pbl-$(CONFIG_CPU_32v7) += hyp.o
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 3:00 [PATCH] ARM: Do not build hyp.S for AArch64 Andrey Smirnov
2018-11-15 7:41 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox