From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] aiodev: mc13xxx: Mark mc13xxx_adc_do_conversion() static
Date: Fri, 16 Nov 2018 08:47:15 +0100 [thread overview]
Message-ID: <20181116074715.ssfhmje4xuvy66fd@pengutronix.de> (raw)
In-Reply-To: <20181115185700.24823-1-andrew.smirnov@gmail.com>
On Thu, Nov 15, 2018 at 10:56:58AM -0800, Andrey Smirnov wrote:
> Mark mc13xxx_adc_do_conversion() static because it is not used outside
> the source file.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/aiodev/mc13xxx_adc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks. More of these please ;)
Sascha
>
> diff --git a/drivers/aiodev/mc13xxx_adc.c b/drivers/aiodev/mc13xxx_adc.c
> index 4e7204816..d445d1ec6 100644
> --- a/drivers/aiodev/mc13xxx_adc.c
> +++ b/drivers/aiodev/mc13xxx_adc.c
> @@ -75,8 +75,9 @@ to_mc13xx_adc_data(struct aiochannel *chan)
> return container_of(chan->aiodev, struct mc13xx_adc_data, aiodev);
> }
>
> -int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
> - unsigned int channel, unsigned int *sample)
> +static int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
> + unsigned int channel,
> + unsigned int *sample)
> {
> int i;
> int timeout = 100;
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-11-16 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 18:56 Andrey Smirnov
2018-11-15 18:56 ` [PATCH 2/3] net/e1000: Mark e1000_igb_get_flash_size() static Andrey Smirnov
2018-11-15 18:57 ` [PATCH 3/3] net/e1000: Mark e1000_register_invm() static Andrey Smirnov
2018-11-16 7:47 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116074715.ssfhmje4xuvy66fd@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox