[PATCH 1/3] aiodev: mc13xxx: Mark mc13xxx_adc_do_conversion() static

[PATCH 1/3] aiodev: mc13xxx: Mark mc13xxx_adc_do_conversion() static

[Andrey Smirnov]

Mark mc13xxx_adc_do_conversion() static because it is not used outside
the source file.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/aiodev/mc13xxx_adc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/aiodev/mc13xxx_adc.c b/drivers/aiodev/mc13xxx_adc.c
index 4e7204816..d445d1ec6 100644
--- a/drivers/aiodev/mc13xxx_adc.c
+++ b/drivers/aiodev/mc13xxx_adc.c
@@ -75,8 +75,9 @@ to_mc13xx_adc_data(struct aiochannel *chan)
 	return container_of(chan->aiodev, struct mc13xx_adc_data, aiodev);
 }
 
-int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
-		unsigned int channel, unsigned int *sample)
+static int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
+				     unsigned int channel,
+				     unsigned int *sample)
 {
 	int i;
 	int timeout = 100;
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/3] net/e1000: Mark e1000_igb_get_flash_size() static

[Andrey Smirnov]

Mark e1000_igb_get_flash_size() static because it is not used outside
the source file.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/net/e1000/eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c
index ce74a8b20..aec533325 100644
--- a/drivers/net/e1000/eeprom.c
+++ b/drivers/net/e1000/eeprom.c
@@ -407,7 +407,7 @@ static void e1000_eeprom_uses_microwire(struct e1000_eeprom_info *eeprom,
 	eeprom->read = e1000_read_eeprom_microwire;
 }
 
-size_t e1000_igb_get_flash_size(struct e1000_hw *hw)
+static size_t e1000_igb_get_flash_size(struct e1000_hw *hw)
 {
 	struct device_node *node =
 		hw->pdev->dev.device_node;
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/3] net/e1000: Mark e1000_register_invm() static

[Andrey Smirnov]

Mark e1000_register_invm() static because it is not used outside the
source file.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/net/e1000/eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c
index aec533325..c0f2db552 100644
--- a/drivers/net/e1000/eeprom.c
+++ b/drivers/net/e1000/eeprom.c
@@ -1504,7 +1504,7 @@ static int e1000_mtd_unlock(struct mtd_info *mtd, loff_t ofs, size_t len)
 	return e1000_mtd_sr_rmw(mtd, SR_BPALL, 0x0);
 }
 
-int e1000_register_invm(struct e1000_hw *hw)
+static int e1000_register_invm(struct e1000_hw *hw)
 {
 	int ret;
 	u16 word;
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/3] aiodev: mc13xxx: Mark mc13xxx_adc_do_conversion() static

[Sascha Hauer]

On Thu, Nov 15, 2018 at 10:56:58AM -0800, Andrey Smirnov wrote:
> Mark mc13xxx_adc_do_conversion() static because it is not used outside
> the source file.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/aiodev/mc13xxx_adc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks. More of these please ;)

Sascha

> 
> diff --git a/drivers/aiodev/mc13xxx_adc.c b/drivers/aiodev/mc13xxx_adc.c
> index 4e7204816..d445d1ec6 100644
> --- a/drivers/aiodev/mc13xxx_adc.c
> +++ b/drivers/aiodev/mc13xxx_adc.c
> @@ -75,8 +75,9 @@ to_mc13xx_adc_data(struct aiochannel *chan)
>  	return container_of(chan->aiodev, struct mc13xx_adc_data, aiodev);
>  }
>  
> -int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
> -		unsigned int channel, unsigned int *sample)
> +static int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx,
> +				     unsigned int channel,
> +				     unsigned int *sample)
>  {
>  	int i;
>  	int timeout = 100;
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox