mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 3/5] video/ssd1307fb: fix potential memory leak on error
Date: Fri, 16 Nov 2018 08:52:32 +0100	[thread overview]
Message-ID: <20181116075232.bgbgqjwomgvzukft@pengutronix.de> (raw)
In-Reply-To: <20181110075954.32746-4-linux@rempel-privat.de>

On Sat, Nov 10, 2018 at 08:59:52AM +0100, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
>  drivers/video/ssd1307fb.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/ssd1307fb.c b/drivers/video/ssd1307fb.c
> index d68f0c505..1fd1a3cfb 100644
> --- a/drivers/video/ssd1307fb.c
> +++ b/drivers/video/ssd1307fb.c
> @@ -548,8 +548,11 @@ static int ssd1307fb_probe(struct device_d *dev)
>  	/* clear display */
>  	array = ssd1307fb_alloc_array(par->width * par->height / 8,
>  				      SSD1307FB_DATA);
> -	if (!array)
> -		return -ENOMEM;
> +	if (!array) {
> +		dev_err(&client->dev, "Couldn't not allocate an array\n");

Please do not add messages in allocation failure pathes. When we get out
of memory it's not really interesting where it happened, at least not
when it's not the culprit itself. It would rather be interesting who ate
all your memory before.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-11-16  7:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10  7:59 [PATCH v1 0/5] random fixes Oleksij Rempel
2018-11-10  7:59 ` [PATCH v1 1/5] commands: keystore: init s_len Oleksij Rempel
2018-11-12  7:34   ` Sascha Hauer
2018-11-10  7:59 ` [PATCH v1 2/5] ddr_spd: remove unused array Oleksij Rempel
2018-11-10  7:59 ` [PATCH v1 3/5] video/ssd1307fb: fix potential memory leak on error Oleksij Rempel
2018-11-16  7:52   ` Sascha Hauer [this message]
2018-11-10  7:59 ` [PATCH v1 4/5] clk: imx: cpu: avoid use after free " Oleksij Rempel
2018-11-12  7:36   ` Sascha Hauer
2018-11-10  7:59 ` [PATCH v1 5/5] of: partition: set ret for error cases Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181116075232.bgbgqjwomgvzukft@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox