mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 09/12] usb: musb: Add missing includes
Date: Mon, 19 Nov 2018 09:44:51 +0100	[thread overview]
Message-ID: <20181119084454.17599-10-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20181119084454.17599-1-s.hauer@pengutronix.de>

phy-am335x.c and phy-am335x-control.c both implement functions that they
do not include the header file providing the prototype for. Add the
missing include and remove the duplicate definition of struct
phy_control.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/usb/musb/phy-am335x-control.c | 5 +----
 drivers/usb/musb/phy-am335x.c         | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/musb/phy-am335x-control.c b/drivers/usb/musb/phy-am335x-control.c
index 55a2ed27b7..c84525ec7e 100644
--- a/drivers/usb/musb/phy-am335x-control.c
+++ b/drivers/usb/musb/phy-am335x-control.c
@@ -4,10 +4,7 @@
 #include <linux/err.h>
 #include <linux/spinlock.h>
 
-struct phy_control {
-	void (*phy_power)(struct phy_control *phy_ctrl, u32 id, bool on);
-	void (*phy_wkup)(struct phy_control *phy_ctrl, u32 id, bool on);
-};
+#include "am35x-phy-control.h"
 
 struct am335x_control_usb {
 	struct device_d *dev;
diff --git a/drivers/usb/musb/phy-am335x.c b/drivers/usb/musb/phy-am335x.c
index ec8c0f538b..df31255d89 100644
--- a/drivers/usb/musb/phy-am335x.c
+++ b/drivers/usb/musb/phy-am335x.c
@@ -5,6 +5,7 @@
 #include <linux/err.h>
 #include "am35x-phy-control.h"
 #include "musb_core.h"
+#include "phy-am335x.h"
 
 struct am335x_usbphy {
 	void __iomem *base;
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-11-19  8:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19  8:44 [PATCH 00/12] More -Wmissing-prototypes fixes Sascha Hauer
2018-11-19  8:44 ` [PATCH 01/12] ARM: start: Add missing prototype Sascha Hauer
2018-11-19  8:44 ` [PATCH 02/12] ARM: samsung: remove unused function Sascha Hauer
2018-11-19  8:44 ` [PATCH 03/12] ARM: samsung: make locally used function static Sascha Hauer
2018-11-19  8:44 ` [PATCH 04/12] ARM: samsung: provide prototype for nand_boot() Sascha Hauer
2018-11-19  8:44 ` [PATCH 05/12] ARM: samsung: Add missing include Sascha Hauer
2018-11-19  8:44 ` [PATCH 06/12] state: remove unused function Sascha Hauer
2018-11-19  8:44 ` [PATCH 07/12] mtd: nand: omap: Add header file for bch decoder Sascha Hauer
2018-11-19  8:44 ` [PATCH 08/12] net: cpsw: Make locally used function static Sascha Hauer
2018-11-19  8:44 ` Sascha Hauer [this message]
2018-11-19  8:44 ` [PATCH 10/12] spi: omap: make locally used functions static Sascha Hauer
2018-11-19  8:44 ` [PATCH 11/12] bus: omap-gpmc: make locally used function static Sascha Hauer
2018-11-19  8:44 ` [PATCH 12/12] ARM: omap: Add missing includes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119084454.17599-10-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox