From: Sascha Hauer <s.hauer@pengutronix.de>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm: boards: phytec-som-am335x: Fix mac overwrite from state
Date: Wed, 21 Nov 2018 09:03:00 +0100 [thread overview]
Message-ID: <20181121080300.hutupwph3j66m5kw@pengutronix.de> (raw)
In-Reply-To: <1542721630-8082-1-git-send-email-t.remmet@phytec.de>
On Tue, Nov 20, 2018 at 02:47:10PM +0100, Teresa Remmet wrote:
> state_read_mac() returns 0 on success so mac never was overwritten.
> Fix this and add check for valid mac address.
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> arch/arm/boards/phytec-som-am335x/board.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/boards/phytec-som-am335x/board.c b/arch/arm/boards/phytec-som-am335x/board.c
> index 8c24f2b33249..441d56348cc7 100644
> --- a/arch/arm/boards/phytec-som-am335x/board.c
> +++ b/arch/arm/boards/phytec-som-am335x/board.c
> @@ -73,7 +73,7 @@ static const char *eth_names[ETH_COUNT] = {"mac0", "mac1"};
> static int physom_devices_init(void)
> {
> struct state *state;
> - u8 mac[6];
> + uint8_t mac[6];
> int state_ret;
> int state_i;
>
> @@ -130,7 +130,7 @@ static int physom_devices_init(void)
> for (state_i = 0; state_i < 2; state_i++) {
> state_ret = state_read_mac(state,
> eth_names[state_i], &mac[0]);
> - if (state_ret == 6)
> + if (!state_ret && is_valid_ether_addr(&mac[0]))
> eth_register_ethaddr(state_i, mac);
> }
> }
> --
> 2.7.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-11-21 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:47 Teresa Remmet
2018-11-21 8:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121080300.hutupwph3j66m5kw@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox