mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] arch: *: cpuinfo: harmonize command description
@ 2018-11-22  8:12 Ulrich Ölmann
  2018-11-22 15:39 ` Antony Pavlov
  0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Ölmann @ 2018-11-22  8:12 UTC (permalink / raw)
  To: Barebox List

Unify the different cpuinfo commands' description and adjust them to the
descriptions of "clk_dump" and "devinfo".

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
 arch/arm/cpu/cpuinfo.c      | 2 +-
 arch/mips/lib/cpuinfo.c     | 2 +-
 arch/openrisc/lib/cpuinfo.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/cpu/cpuinfo.c b/arch/arm/cpu/cpuinfo.c
index 175475b038dc..2421b91e57f1 100644
--- a/arch/arm/cpu/cpuinfo.c
+++ b/arch/arm/cpu/cpuinfo.c
@@ -268,7 +268,7 @@ static int do_cpuinfo(int argc, char *argv[])
 
 BAREBOX_CMD_START(cpuinfo)
 	.cmd            = do_cpuinfo,
-	BAREBOX_CMD_DESC("show info about CPU")
+	BAREBOX_CMD_DESC("show information about CPU")
 	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
 	BAREBOX_CMD_COMPLETE(empty_complete)
 BAREBOX_CMD_END
diff --git a/arch/mips/lib/cpuinfo.c b/arch/mips/lib/cpuinfo.c
index fb02a4d20217..a327672f78a5 100644
--- a/arch/mips/lib/cpuinfo.c
+++ b/arch/mips/lib/cpuinfo.c
@@ -63,6 +63,6 @@ static int do_cpuinfo(int argc, char *argv[])
 
 BAREBOX_CMD_START(cpuinfo)
 	.cmd            = do_cpuinfo,
-	BAREBOX_CMD_DESC("show CPU information")
+	BAREBOX_CMD_DESC("show information about CPU")
 	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
 BAREBOX_CMD_END
diff --git a/arch/openrisc/lib/cpuinfo.c b/arch/openrisc/lib/cpuinfo.c
index 175adc582ca4..3d7fcb1f59ce 100644
--- a/arch/openrisc/lib/cpuinfo.c
+++ b/arch/openrisc/lib/cpuinfo.c
@@ -198,6 +198,6 @@ static int do_cpuinfo(int argc, char *argv[])
 
 BAREBOX_CMD_START(cpuinfo)
 	.cmd            = do_cpuinfo,
-	BAREBOX_CMD_DESC("show CPU information")
+	BAREBOX_CMD_DESC("show information about CPU")
 	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
 BAREBOX_CMD_END
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] arch: *: cpuinfo: harmonize command description
  2018-11-22  8:12 [PATCH] arch: *: cpuinfo: harmonize command description Ulrich Ölmann
@ 2018-11-22 15:39 ` Antony Pavlov
  2018-11-27  8:59   ` Ulrich Ölmann
  0 siblings, 1 reply; 3+ messages in thread
From: Antony Pavlov @ 2018-11-22 15:39 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Barebox List

On Thu, 22 Nov 2018 09:12:00 +0100
Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:

Hello Robert!

AFAIR you are a native English speaker.

Would you please comment this change

> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")

Which version of the cpuinfo command description is better?

-- 
Best regards,
  Antony Pavlov

> Unify the different cpuinfo commands' description and adjust them to the
> descriptions of "clk_dump" and "devinfo".
> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  arch/arm/cpu/cpuinfo.c      | 2 +-
>  arch/mips/lib/cpuinfo.c     | 2 +-
>  arch/openrisc/lib/cpuinfo.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/cpuinfo.c b/arch/arm/cpu/cpuinfo.c
> index 175475b038dc..2421b91e57f1 100644
> --- a/arch/arm/cpu/cpuinfo.c
> +++ b/arch/arm/cpu/cpuinfo.c
> @@ -268,7 +268,7 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show info about CPU")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  	BAREBOX_CMD_COMPLETE(empty_complete)
>  BAREBOX_CMD_END
> diff --git a/arch/mips/lib/cpuinfo.c b/arch/mips/lib/cpuinfo.c
> index fb02a4d20217..a327672f78a5 100644
> --- a/arch/mips/lib/cpuinfo.c
> +++ b/arch/mips/lib/cpuinfo.c
> @@ -63,6 +63,6 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  BAREBOX_CMD_END
> diff --git a/arch/openrisc/lib/cpuinfo.c b/arch/openrisc/lib/cpuinfo.c
> index 175adc582ca4..3d7fcb1f59ce 100644
> --- a/arch/openrisc/lib/cpuinfo.c
> +++ b/arch/openrisc/lib/cpuinfo.c
> @@ -198,6 +198,6 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  BAREBOX_CMD_END
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] arch: *: cpuinfo: harmonize command description
  2018-11-22 15:39 ` Antony Pavlov
@ 2018-11-27  8:59   ` Ulrich Ölmann
  0 siblings, 0 replies; 3+ messages in thread
From: Ulrich Ölmann @ 2018-11-27  8:59 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: Barebox List, Robert P. J. Day

Hi Antony & Robert,

On Thu, Nov 22 2018 at 14:39 +0100, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> On Thu, 22 Nov 2018 09:12:00 +0100
> Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
>
> Hello Robert!
>
> AFAIR you are a native English speaker.
>
> Would you please comment this change
>
>> -	BAREBOX_CMD_DESC("show CPU information")
>> +	BAREBOX_CMD_DESC("show information about CPU")
>
> Which version of the cpuinfo command description is better?

I do not stick to the command description suggested in my patch and in
particular have no preference for one or the other of the above
alternatives - native speakers stand up: advice welcome! ;-)

The motivation for my patch was only the harmonization of things after
accidentally stumbling across different descriptions for the same
command. So perhaps let's harmonize the other commands' descriptions as
well and do it altogether in a v2.

Best regards
Ulrich
--
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-27  9:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-22  8:12 [PATCH] arch: *: cpuinfo: harmonize command description Ulrich Ölmann
2018-11-22 15:39 ` Antony Pavlov
2018-11-27  8:59   ` Ulrich Ölmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox