mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] arch: *: cpuinfo: harmonize command description
Date: Thu, 22 Nov 2018 18:39:18 +0300	[thread overview]
Message-ID: <20181122183918.e222c20e51c6e41afcfd5d6a@gmail.com> (raw)
In-Reply-To: <20181122081200.12642-1-u.oelmann@pengutronix.de>

On Thu, 22 Nov 2018 09:12:00 +0100
Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:

Hello Robert!

AFAIR you are a native English speaker.

Would you please comment this change

> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")

Which version of the cpuinfo command description is better?

-- 
Best regards,
  Antony Pavlov

> Unify the different cpuinfo commands' description and adjust them to the
> descriptions of "clk_dump" and "devinfo".
> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  arch/arm/cpu/cpuinfo.c      | 2 +-
>  arch/mips/lib/cpuinfo.c     | 2 +-
>  arch/openrisc/lib/cpuinfo.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/cpuinfo.c b/arch/arm/cpu/cpuinfo.c
> index 175475b038dc..2421b91e57f1 100644
> --- a/arch/arm/cpu/cpuinfo.c
> +++ b/arch/arm/cpu/cpuinfo.c
> @@ -268,7 +268,7 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show info about CPU")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  	BAREBOX_CMD_COMPLETE(empty_complete)
>  BAREBOX_CMD_END
> diff --git a/arch/mips/lib/cpuinfo.c b/arch/mips/lib/cpuinfo.c
> index fb02a4d20217..a327672f78a5 100644
> --- a/arch/mips/lib/cpuinfo.c
> +++ b/arch/mips/lib/cpuinfo.c
> @@ -63,6 +63,6 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  BAREBOX_CMD_END
> diff --git a/arch/openrisc/lib/cpuinfo.c b/arch/openrisc/lib/cpuinfo.c
> index 175adc582ca4..3d7fcb1f59ce 100644
> --- a/arch/openrisc/lib/cpuinfo.c
> +++ b/arch/openrisc/lib/cpuinfo.c
> @@ -198,6 +198,6 @@ static int do_cpuinfo(int argc, char *argv[])
>  
>  BAREBOX_CMD_START(cpuinfo)
>  	.cmd            = do_cpuinfo,
> -	BAREBOX_CMD_DESC("show CPU information")
> +	BAREBOX_CMD_DESC("show information about CPU")
>  	BAREBOX_CMD_GROUP(CMD_GRP_INFO)
>  BAREBOX_CMD_END
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-11-22 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22  8:12 Ulrich Ölmann
2018-11-22 15:39 ` Antony Pavlov [this message]
2018-11-27  8:59   ` Ulrich Ölmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181122183918.e222c20e51c6e41afcfd5d6a@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox