mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <r.hieber@pengutronix.de>
To: Rouven Czerwinski <rouven@czerwinskis.de>
Cc: barebox@lists.infradead.org, Michael Tretter <m.tretter@pengutronix.de>
Subject: Re: [PATCH 3/3] ARM: zynqmp: add support for Xilinx ZCU104 board
Date: Mon, 26 Nov 2018 11:37:39 +0100	[thread overview]
Message-ID: <20181126103739.io46y3azn4zstvzw@pengutronix.de> (raw)
In-Reply-To: <87pnuv525v.fsf@czerwinskis.de>

On Fri, Nov 23, 2018 at 02:55:24PM +0100, Rouven Czerwinski wrote:
> Michael Tretter <m.tretter@pengutronix.de> writes:
[...]
> > +static inline void PUTC_LL(int c)
> > +{
> > +	void __iomem *base = (void __iomem *)ZYNQMP_DEBUG_LL_UART_BASE;
> > +
> > +	if (readl(base) & ZYNQMP_UART_TXDIS)
> > +		return;
> > +
> > +	while ((readl(base + ZYNQMP_UART_CHANNEL_STS) & ZYNQMP_UART_STS_TFUL) != 0)
> > +		;
>                 ^ this should be in the previous line

Is there a coding style for that? I find the semicolon better in a
single line to make it more obvious that this is an empty while loop.

 - Roland

> > +
> > +	writel(c, base + 0x30);
> > +}
> > +
> > +#endif

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-11-26 10:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 13:35 [PATCH 0/3] Xilinx Zynq Ultrascale+ MPSoC support Michael Tretter
2018-11-23 13:35 ` [PATCH 1/3] ARM: lib64: .gitignore barebox.lds Michael Tretter
2018-11-23 13:35 ` [PATCH 2/3] ARM: aarch64: compile with general-regs-only Michael Tretter
2018-11-23 13:48   ` Rouven Czerwinski
2018-11-23 13:35 ` [PATCH 3/3] ARM: zynqmp: add support for Xilinx ZCU104 board Michael Tretter
2018-11-23 13:55   ` Rouven Czerwinski
2018-11-26 10:37     ` Roland Hieber [this message]
2018-11-23 14:38   ` Michael Tretter
2018-11-23 15:08   ` Oleksij Rempel
2018-11-23 18:27     ` Michael Tretter
2018-11-23 18:41       ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181126103739.io46y3azn4zstvzw@pengutronix.de \
    --to=r.hieber@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.tretter@pengutronix.de \
    --cc=rouven@czerwinskis.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox