mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org, Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH v1 10/10] MIPS: multiimage: remove useless board files
Date: Mon, 26 Nov 2018 15:22:38 +0300	[thread overview]
Message-ID: <20181126152238.f874c78439fa1ad9b432751c@gmail.com> (raw)
In-Reply-To: <20181126091807.19398-11-o.rempel@pengutronix.de>

On Mon, 26 Nov 2018 10:18:07 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

Hi!

This patch has no relation with multi-image support.
It uses the features introdused in your patch 'of: base: use root_node compatible
as suggestion for a hostname' (76759ec94eb3a3) which is already in mainline.

Can we submit 'remove useless board files' as an independent patch?

> From: Oleksij Rempel <linux@rempel-privat.de>
> 
> With multiimage support we should check OF compatible before executing
> some thing board specific. In most cases we was executing only barebox_set_hostname().
> Since we can extract host name from devicetree, we can drop all of this
> board files.
> 
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
>  arch/mips/boards/black-swift/Makefile    |  1 -
>  arch/mips/boards/black-swift/board.c     | 27 ----------------------
>  arch/mips/boards/img-ci20/Makefile       |  1 -
>  arch/mips/boards/img-ci20/board.c        | 27 ----------------------
>  arch/mips/boards/loongson-ls1b/Makefile  |  1 -
>  arch/mips/boards/loongson-ls1b/serial.c  | 10 --------
>  arch/mips/boards/qemu-malta/Makefile     |  1 -
>  arch/mips/boards/qemu-malta/init.c       | 29 ------------------------
>  arch/mips/boards/ritmix-rzx50/Makefile   |  1 -
>  arch/mips/boards/ritmix-rzx50/serial.c   | 27 ----------------------
>  arch/mips/boards/tplink-mr3020/Makefile  |  1 -
>  arch/mips/boards/tplink-mr3020/board.c   | 27 ----------------------
>  arch/mips/boards/tplink-wdr4300/Makefile |  1 -
>  arch/mips/boards/tplink-wdr4300/board.c  | 28 -----------------------
>  14 files changed, 182 deletions(-)
>  delete mode 100644 arch/mips/boards/black-swift/board.c
>  delete mode 100644 arch/mips/boards/img-ci20/board.c
>  delete mode 100644 arch/mips/boards/loongson-ls1b/serial.c
>  delete mode 100644 arch/mips/boards/qemu-malta/init.c
>  delete mode 100644 arch/mips/boards/ritmix-rzx50/serial.c
>  delete mode 100644 arch/mips/boards/tplink-mr3020/board.c
>  delete mode 100644 arch/mips/boards/tplink-wdr4300/board.c
> 
> diff --git a/arch/mips/boards/black-swift/Makefile b/arch/mips/boards/black-swift/Makefile
> index 092c31d6b2..b08c4a93ca 100644
> --- a/arch/mips/boards/black-swift/Makefile
> +++ b/arch/mips/boards/black-swift/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += board.o
> diff --git a/arch/mips/boards/black-swift/board.c b/arch/mips/boards/black-swift/board.c
> deleted file mode 100644
> index 2e2ed2075b..0000000000
> --- a/arch/mips/boards/black-swift/board.c
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/*
> - * Copyright (C) 2015 Antony Pavlov <antonynpavlov@gmail.com>
> - *
> - * This file is part of barebox.
> - * See file CREDITS for list of people who contributed to this project.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - */
> -
> -#include <common.h>
> -#include <init.h>
> -
> -static int model_hostname_init(void)
> -{
> -	barebox_set_hostname("black-swift");
> -
> -	return 0;
> -}
> -postcore_initcall(model_hostname_init);
> diff --git a/arch/mips/boards/img-ci20/Makefile b/arch/mips/boards/img-ci20/Makefile
> index 092c31d6b2..b08c4a93ca 100644
> --- a/arch/mips/boards/img-ci20/Makefile
> +++ b/arch/mips/boards/img-ci20/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += board.o
> diff --git a/arch/mips/boards/img-ci20/board.c b/arch/mips/boards/img-ci20/board.c
> deleted file mode 100644
> index 515ebaece6..0000000000
> --- a/arch/mips/boards/img-ci20/board.c
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/*
> - * Copyright (C) 2012 Antony Pavlov <antonynpavlov@gmail.com>
> - *
> - * This file is part of barebox.
> - * See file CREDITS for list of people who contributed to this project.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - */
> -
> -#include <common.h>
> -#include <init.h>
> -
> -static int ci20_hostname_init(void)
> -{
> -	barebox_set_hostname("ci20");
> -
> -	return 0;
> -}
> -console_initcall(ci20_hostname_init);
> diff --git a/arch/mips/boards/loongson-ls1b/Makefile b/arch/mips/boards/loongson-ls1b/Makefile
> index ded9867a8e..b08c4a93ca 100644
> --- a/arch/mips/boards/loongson-ls1b/Makefile
> +++ b/arch/mips/boards/loongson-ls1b/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += serial.o
> diff --git a/arch/mips/boards/loongson-ls1b/serial.c b/arch/mips/boards/loongson-ls1b/serial.c
> deleted file mode 100644
> index a9453ede28..0000000000
> --- a/arch/mips/boards/loongson-ls1b/serial.c
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -#include <common.h>
> -#include <init.h>
> -
> -static int console_init(void)
> -{
> -	barebox_set_hostname("ls1b");
> -
> -	return 0;
> -}
> -console_initcall(console_init);
> diff --git a/arch/mips/boards/qemu-malta/Makefile b/arch/mips/boards/qemu-malta/Makefile
> index 237a6a5079..b08c4a93ca 100644
> --- a/arch/mips/boards/qemu-malta/Makefile
> +++ b/arch/mips/boards/qemu-malta/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += init.o
> diff --git a/arch/mips/boards/qemu-malta/init.c b/arch/mips/boards/qemu-malta/init.c
> deleted file mode 100644
> index 24bfdc03ee..0000000000
> --- a/arch/mips/boards/qemu-malta/init.c
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -/*
> - * Copyright (C) 2011 Antony Pavlov <antonynpavlov@gmail.com>
> - * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> - *
> - * This file is part of barebox.
> - * See file CREDITS for list of people who contributed to this project.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - */
> -
> -#include <common.h>
> -#include <init.h>
> -#include <linux/sizes.h>
> -
> -static int malta_core_init(void)
> -{
> -	barebox_set_hostname("malta");
> -
> -	return 0;
> -}
> -core_initcall(malta_core_init);
> diff --git a/arch/mips/boards/ritmix-rzx50/Makefile b/arch/mips/boards/ritmix-rzx50/Makefile
> index ded9867a8e..b08c4a93ca 100644
> --- a/arch/mips/boards/ritmix-rzx50/Makefile
> +++ b/arch/mips/boards/ritmix-rzx50/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += serial.o
> diff --git a/arch/mips/boards/ritmix-rzx50/serial.c b/arch/mips/boards/ritmix-rzx50/serial.c
> deleted file mode 100644
> index f1e8da0072..0000000000
> --- a/arch/mips/boards/ritmix-rzx50/serial.c
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/*
> - * Copyright (C) 2012 Antony Pavlov <antonynpavlov@gmail.com>
> - *
> - * This file is part of barebox.
> - * See file CREDITS for list of people who contributed to this project.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - */
> -
> -#include <common.h>
> -#include <init.h>
> -
> -static int rzx50_hostname_init(void)
> -{
> -	barebox_set_hostname("rzx50");
> -
> -	return 0;
> -}
> -console_initcall(rzx50_hostname_init);
> diff --git a/arch/mips/boards/tplink-mr3020/Makefile b/arch/mips/boards/tplink-mr3020/Makefile
> index 092c31d6b2..b08c4a93ca 100644
> --- a/arch/mips/boards/tplink-mr3020/Makefile
> +++ b/arch/mips/boards/tplink-mr3020/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += board.o
> diff --git a/arch/mips/boards/tplink-mr3020/board.c b/arch/mips/boards/tplink-mr3020/board.c
> deleted file mode 100644
> index 318998cc49..0000000000
> --- a/arch/mips/boards/tplink-mr3020/board.c
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/*
> - * Copyright (C) 2014 Antony Pavlov <antonynpavlov@gmail.com>
> - *
> - * This file is part of barebox.
> - * See file CREDITS for list of people who contributed to this project.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - */
> -
> -#include <common.h>
> -#include <init.h>
> -
> -static int model_hostname_init(void)
> -{
> -	barebox_set_hostname("mr3020");
> -
> -	return 0;
> -}
> -postcore_initcall(model_hostname_init);
> diff --git a/arch/mips/boards/tplink-wdr4300/Makefile b/arch/mips/boards/tplink-wdr4300/Makefile
> index 092c31d6b2..b08c4a93ca 100644
> --- a/arch/mips/boards/tplink-wdr4300/Makefile
> +++ b/arch/mips/boards/tplink-wdr4300/Makefile
> @@ -1,2 +1 @@
>  lwl-y += lowlevel.o
> -obj-y += board.o
> diff --git a/arch/mips/boards/tplink-wdr4300/board.c b/arch/mips/boards/tplink-wdr4300/board.c
> deleted file mode 100644
> index d6126fcb6d..0000000000
> --- a/arch/mips/boards/tplink-wdr4300/board.c
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -/*
> - * Copyright (C) 2017 Oleksij Rempel <o.rempel@pengutronix.de>
> - * Copyright (C) 2014 Antony Pavlov <antonynpavlov@gmail.com>
> - *
> - * This file is part of barebox.
> - * See file CREDITS for list of people who contributed to this project.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2
> - * as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - */
> -
> -#include <common.h>
> -#include <init.h>
> -
> -static int model_hostname_init(void)
> -{
> -	barebox_set_hostname("wdr4300");
> -
> -	return 0;
> -}
> -postcore_initcall(model_hostname_init);
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-11-26 12:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  9:17 [PATCH v1 00/10] MIPS: migrate to multiimage support Oleksij Rempel
2018-11-26  9:17 ` [PATCH v1 01/10] images: piggy: use "a" instead of #alloc flag Oleksij Rempel
2018-11-26 12:25   ` Antony Pavlov
2018-11-26 13:00     ` Oleksij Rempel
2018-11-26  9:17 ` [PATCH v1 02/10] MIPS: add arch/mips/lib/pbl.lds.S Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 03/10] pbl: enable MIPS for PBL_RELOCATABLE Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 04/10] MIPS: start: preserve DTB pointer for later use Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 06/10] MIPS: mutliimage: pass devicetree from PBL to the main_entry Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 07/10] MIPS: put main_entry to __bare_init section Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 08/10] MIPS: port all mach* to multiimage Oleksij Rempel
2018-11-26 12:13   ` Antony Pavlov
2018-11-26 13:02     ` Oleksij Rempel
2018-11-26 13:01   ` Antony Pavlov
2018-11-26 13:54     ` Oleksij Rempel
2018-11-26 14:15       ` Sascha Hauer
2018-11-26  9:18 ` [PATCH v1 09/10] MIPS: remove HAS_NO_BOARD_HL_CODE support Oleksij Rempel
2018-11-26  9:18 ` [PATCH v1 10/10] MIPS: multiimage: remove useless board files Oleksij Rempel
2018-11-26 12:22   ` Antony Pavlov [this message]
2018-11-26 13:01     ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181126152238.f874c78439fa1ad9b432751c@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox