From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros
Date: Tue, 27 Nov 2018 09:04:17 +0100 [thread overview]
Message-ID: <20181127080417.fj52tvzngiv2kpih@pengutronix.de> (raw)
In-Reply-To: <20181127073714.16472-6-o.rempel@pengutronix.de>
On Tue, Nov 27, 2018 at 08:37:09AM +0100, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/mips/include/asm/asm.h | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/arch/mips/include/asm/asm.h b/arch/mips/include/asm/asm.h
> index 12e17581b8..b9ccccc0cc 100644
> --- a/arch/mips/include/asm/asm.h
> +++ b/arch/mips/include/asm/asm.h
> @@ -79,6 +79,35 @@ symbol: .frame sp, framesize, rpc
> .globl symbol; \
> symbol:
>
> +/*
> + * ENTRY_FUNCTION - mark start of entry function
> + */
> +#define ENTRY_FUNCTION(symbol) \
> + .set noreorder; \
> + .section .text_head_entry.BOARD_PBL_START; \
In your boards you have:
#define BOARD_PBL_START start_8devices_lima
ENTRY_FUNCTION(BOARD_PBL_START)
It's strange that you pass in the same string both as macro argument and
preprocessor define. Seems like you should drop BOARD_PBL_START and use
"symbol" directly.
> + \
> + la a0, dtb_start; \
> + la a1, dtb_end; \
> + la v0, pbl_main_entry; \
> + jal v0; \
> + nop; \
Whitespace inconsistency here.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-11-27 8:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 7:37 [PATCH v2 00/10] MIPS: migrate to multiimage support Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 01/10] images: piggy: use "a" instead of #alloc flag Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 02/10] MIPS: add arch/mips/lib/pbl.lds.S Oleksij Rempel
2018-11-27 7:58 ` Sascha Hauer
2018-11-27 7:37 ` [PATCH v2 03/10] pbl: enable MIPS for PBL_RELOCATABLE Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 04/10] MIPS: start: preserve DTB pointer for later use Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros Oleksij Rempel
2018-11-27 8:04 ` Sascha Hauer [this message]
2018-11-27 10:15 ` Antony Pavlov
2018-11-27 7:37 ` [PATCH v2 06/10] MIPS: mutliimage: pass devicetree from PBL to the main_entry Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 07/10] MIPS: put main_entry to __bare_init section Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 08/10] MIPS: port all mach* to multiimage Oleksij Rempel
2018-11-27 8:10 ` Sascha Hauer
2018-11-27 7:37 ` [PATCH v2 09/10] MIPS: remove HAS_NO_BOARD_HL_CODE support Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 10/10] MIPS: remove useless board files Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127080417.fj52tvzngiv2kpih@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox