From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH v2 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros
Date: Tue, 27 Nov 2018 13:15:57 +0300 [thread overview]
Message-ID: <20181127131557.5b90d841b1dc5a2a27416a09@gmail.com> (raw)
In-Reply-To: <20181127080417.fj52tvzngiv2kpih@pengutronix.de>
On Tue, 27 Nov 2018 09:04:17 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > + \
> > + la a0, dtb_start; \
> > + la a1, dtb_end; \
> > + la v0, pbl_main_entry; \
> > + jal v0; \
> > + nop; \
>
> Whitespace inconsistency here.
No whitespace inconsistency here.
Extra whitespace before nop is used because the nop instruction is in delay slot of the jal instruction.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-11-27 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 7:37 [PATCH v2 00/10] MIPS: migrate to multiimage support Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 01/10] images: piggy: use "a" instead of #alloc flag Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 02/10] MIPS: add arch/mips/lib/pbl.lds.S Oleksij Rempel
2018-11-27 7:58 ` Sascha Hauer
2018-11-27 7:37 ` [PATCH v2 03/10] pbl: enable MIPS for PBL_RELOCATABLE Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 04/10] MIPS: start: preserve DTB pointer for later use Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros Oleksij Rempel
2018-11-27 8:04 ` Sascha Hauer
2018-11-27 10:15 ` Antony Pavlov [this message]
2018-11-27 7:37 ` [PATCH v2 06/10] MIPS: mutliimage: pass devicetree from PBL to the main_entry Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 07/10] MIPS: put main_entry to __bare_init section Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 08/10] MIPS: port all mach* to multiimage Oleksij Rempel
2018-11-27 8:10 ` Sascha Hauer
2018-11-27 7:37 ` [PATCH v2 09/10] MIPS: remove HAS_NO_BOARD_HL_CODE support Oleksij Rempel
2018-11-27 7:37 ` [PATCH v2 10/10] MIPS: remove useless board files Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127131557.5b90d841b1dc5a2a27416a09@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox