mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] multiple/raspberry-pi: fix clkdevs for raspberry pi
Date: Thu, 29 Nov 2018 08:50:12 +0100	[thread overview]
Message-ID: <20181129075012.cv6g5r2w4a5wuqn4@pengutronix.de> (raw)
In-Reply-To: <20181127124502.13785-1-r.czerwinski@pengutronix.de>

On Tue, Nov 27, 2018 at 01:45:02PM +0100, Rouven Czerwinski wrote:
> Commit 7e497d48acbd1184e3f6bd23bd16dfae84dd1129 introduced a name change which
> breaks support for the fixed clkdev for uart and sdhci for RPI.
> Use clkdev_add_physbase instead to be independant from the device tree names.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  arch/arm/boards/raspberry-pi/rpi-common.c | 4 ++--
>  arch/arm/mach-bcm283x/core.c              | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks

Sascha

> 
> diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
> index 3baed65255..b7ce0ad425 100644
> --- a/arch/arm/boards/raspberry-pi/rpi-common.c
> +++ b/arch/arm/boards/raspberry-pi/rpi-common.c
> @@ -290,8 +290,8 @@ static int rpi_clock_init(void)
>  	if (IS_ERR(clk))
>  		return PTR_ERR(clk);
>  
> -	clk_register_clkdev(clk, NULL, "20300000.sdhci");
> -	clk_register_clkdev(clk, NULL, "3f300000.sdhci");
> +	clkdev_add_physbase(clk, 0x20300000, NULL);
> +	clkdev_add_physbase(clk, 0x3f300000, NULL);
>  
>  	return 0;
>  }
> diff --git a/arch/arm/mach-bcm283x/core.c b/arch/arm/mach-bcm283x/core.c
> index 26f0996b1c..f1dcda86f7 100644
> --- a/arch/arm/mach-bcm283x/core.c
> +++ b/arch/arm/mach-bcm283x/core.c
> @@ -40,8 +40,8 @@ static int bcm2835_clk_init(void)
>  
>  	clk = clk_fixed("uart0-pl0110", 3 * 1000 * 1000);
>  	clk_register_clkdev(clk, NULL, "uart0-pl0110");
> -	clk_register_clkdev(clk, NULL, "20201000.serial");
> -	clk_register_clkdev(clk, NULL, "3f201000.serial");
> +	clkdev_add_physbase(clk, 0x20201000, NULL);
> +	clkdev_add_physbase(clk, 0x3f201000, NULL);
>  
>  	clk = clk_fixed("bcm2835-cs", 1 * 1000 * 1000);
>  	clk_register_clkdev(clk, NULL, "bcm2835-cs");
> -- 
> 2.19.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-11-29  7:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  8:51 [PATCH 1/2] mach-bcm283x/core: fix clkdev uarts " Rouven Czerwinski
2018-11-27  8:51 ` [PATCH 2/2] rpi-common: fix sdhci clkdev " Rouven Czerwinski
2018-11-27  8:56   ` Rouven Czerwinski
2018-11-27 12:45 ` [PATCH v2] multiple/raspberry-pi: fix clkdevs " Rouven Czerwinski
2018-11-29  7:50   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129075012.cv6g5r2w4a5wuqn4@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.czerwinski@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox