From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 3/3] net: dns: return error codes
Date: Fri, 30 Nov 2018 10:25:12 +0100 [thread overview]
Message-ID: <20181130092512.xc7sto4xdqvl6zw5@pengutronix.de> (raw)
In-Reply-To: <20181129102127.17158-3-s.hauer@pengutronix.de>
On Thu, Nov 29, 2018 at 11:21:27AM +0100, Sascha Hauer wrote:
> The resolv() function used to return the IP address. When net_udp_new()
> fails we return an error code though which the callers of resolv() take
> as an IP address. This is wrong of course and we could return 0 in this
> case. Instead we return an error code and pass the resolved IP as a
> pointer which allows us to return proper error codes.
>
> This patch also adds error messages and error returns to the various
> callers of resolv() which used to just continue with a zero IP and
> let the user figure out what went wrong.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Thanks, that looks good, thanks.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-11-30 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:21 [PATCH 1/3] net: dns: Use pr_debug Sascha Hauer
2018-11-29 10:21 ` [PATCH 2/3] ping command: Print which host is pinged Sascha Hauer
2018-11-29 10:21 ` [PATCH 3/3] net: dns: return error codes Sascha Hauer
2018-11-30 9:25 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130092512.xc7sto4xdqvl6zw5@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox