From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roland Hieber <r.hieber@pengutronix.de>
Cc: Barebox Mailing List <barebox@lists.infradead.org>
Subject: Re: [PATCH] fixup! drivers: caam: add RNG software self-test
Date: Tue, 4 Dec 2018 08:31:52 +0100 [thread overview]
Message-ID: <20181204073152.ig4az7qfpnkf45g5@pengutronix.de> (raw)
In-Reply-To: <20181203101532.25180-1-r.hieber@pengutronix.de>
On Mon, Dec 03, 2018 at 11:15:32AM +0100, Roland Hieber wrote:
> Fix compile error and warning:
>
> drivers/crypto/caam/rng_self_test.c: In function 'caam_rng_self_test':
> drivers/crypto/caam/rng_self_test.c:167:2: error: expected ';' before '}' token
> }
> ^
> drivers/crypto/caam/rng_self_test.c:134:11: warning: unused variable 'i' [-Wunused-variable]
> int ret, i, desc_size = 0, result_size = 0, job_err = 0;
> ^
>
> Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
> ---
> Hi Sascha,
>
> On Mon, Dec 03, 2018 at 09:01:56AM +0100, Sascha Hauer wrote:
> > Hi Roland,
> >
> > Applied with several adjustments, see below.
>
> Right, thank you for those! I found two small problems left.
Applied, thanks
Sascha
>
> - Roland
> ---
> drivers/crypto/caam/rng_self_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/caam/rng_self_test.c b/drivers/crypto/caam/rng_self_test.c
> index 149b334f23..aab4fa2e47 100644
> --- a/drivers/crypto/caam/rng_self_test.c
> +++ b/drivers/crypto/caam/rng_self_test.c
> @@ -131,7 +131,7 @@ static void rng_self_test_done(struct device_d *dev, u32 *desc, u32 err, void *a
> */
> int caam_rng_self_test(struct device_d *dev, const u8 caam_era, const u8 rngvid, const u8 rngrev)
> {
> - int ret, i, desc_size = 0, result_size = 0, job_err = 0;
> + int ret, desc_size = 0, result_size = 0, job_err = 0;
> const u32 *rng_st_dsc;
> const u8 *exp_result;
> u32 *desc;
> @@ -163,7 +163,7 @@ int caam_rng_self_test(struct device_d *dev, const u8 caam_era, const u8 rngvid,
>
> if (!result || !desc) {
> ret = -ENOMEM;
> - goto err
> + goto err;
> }
>
> construct_rng_self_test_jobdesc(desc, rng_st_dsc, result, desc_size);
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-12-04 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 13:42 [PATCH v2 1/2] " Roland Hieber
2018-11-29 13:42 ` [PATCH v2 2/2] i.MX: HABv4: always print HAB status at boot time Roland Hieber
2018-12-03 8:01 ` [PATCH v2 1/2] drivers: caam: add RNG software self-test Sascha Hauer
2018-12-03 10:15 ` [PATCH] fixup! " Roland Hieber
2018-12-04 7:31 ` Sascha Hauer [this message]
2018-12-03 10:52 ` [PATCH v2 1/2] " Roland Hieber
2018-12-04 7:49 ` Sascha Hauer
2018-12-04 8:20 ` [PATCH] fixup! " Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204073152.ig4az7qfpnkf45g5@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.hieber@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox