mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: macb: dma_sync_* receive buffers
Date: Tue, 4 Dec 2018 08:58:01 +0100	[thread overview]
Message-ID: <20181204075801.rku7i6vfgy55mp2c@pengutronix.de> (raw)
In-Reply-To: <1542380845.23489.24.camel@pengutronix.de>

Ladis,

On Fri, Nov 16, 2018 at 04:07:25PM +0100, Lucas Stach wrote:
> > @@ -237,12 +241,17 @@ static int macb_recv(struct eth_device *edev)
> > >  				taillen = length - headlen;
> > >  				memcpy((void *)NetRxPackets[0],
> > >  				       buffer, headlen);
> > > +				dma_sync_single_for_cpu((unsigned long)macb->rx_buffer,
> > > +							taillen, DMA_FROM_DEVICE);
> > >  				memcpy((void *)NetRxPackets[0] + headlen,
> >  				       macb->rx_buffer, taillen);
> 
> This is missing a dma_sync_single_for_device() here, matching the
> ...for_cpu added above. Otherwise patch looks good.

Any input to this one or an updated patch?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-12-04  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  0:36 Ladislav Michl
2018-11-16 15:07 ` Lucas Stach
2018-12-04  7:58   ` Sascha Hauer [this message]
2019-05-30 12:28     ` Ladislav Michl
2019-06-04  6:49       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204075801.rku7i6vfgy55mp2c@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=ladis@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox